cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9631) updateVMAffinityGroup must require one of the list parameter
Date Fri, 28 Jul 2017 09:32:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104715#comment-16104715
] 

ASF subversion and git services commented on CLOUDSTACK-9631:
-------------------------------------------------------------

Commit 28bc99565b12e0480ae2b86d8d97353696857f52 in cloudstack's branch refs/heads/4.10 from
[~marcaurele]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=28bc995 ]

CLOUDSTACK-9631: API: affinitygroupids or affinitygroupnames must be given (#1798)

Return an exception if both parameter are missing.
This fixes an NPE in AffinityGroupServiceImpl.updateVMAffinityGroups() when the list was null.

Signed-off-by: Marc-Aurèle Brothier <m@brothier.org>

> updateVMAffinityGroup must require one of the list parameter
> ------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9631
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9631
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>            Reporter: Marc-Aurèle Brothier
>            Assignee: Marc-Aurèle Brothier
>
> The command updateVMAffinityGroup does not check that one of the parameter is provided,
therefore if both are null a NPE is raised later on in AffinityGroupServiceImpl (https://github.com/apache/cloudstack/blob/master/server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java#L429).
> The command should check both cases: both list are not given, and one is given.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message