Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Thu, 11 May 2017 19:43:04 +0000 (UTC)
From: "Mike Tutkowski (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.13071309.1494531754000.190882.1494531784098@Atlassian.JIRA>
In-Reply-To: <JIRA.13071309.1494531754000@Atlassian.JIRA>
References: <JIRA.13071309.1494531754000@Atlassian.JIRA> <JIRA.13071309.1494531754090@jira-lw-us.apache.org>
Subject: [jira] [Assigned] (CLOUDSTACK-9917) Root disks stranded on primary
 storage
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 11 May 2017 19:43:09 -0000


     [ https://issues.apache.org/jira/browse/CLOUDSTACK-9917?page=3Dcom.atl=
assian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Tutkowski reassigned CLOUDSTACK-9917:
------------------------------------------

    Assignee: Mike Tutkowski

> Root disks stranded on primary storage
> --------------------------------------
>
>                 Key: CLOUDSTACK-9917
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-991=
7
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the defa=
ult.)=20
>          Components: Management Server
>    Affects Versions: 4.10.0.0
>         Environment: N/A
>            Reporter: Mike Tutkowski
>            Assignee: Mike Tutkowski
>            Priority: Blocker
>             Fix For: 4.10.0.0
>
>
> From dev@
>    OK, here=E2=80=99s the gist of the problem:
>    In StorageManagerImpl.cleanupStorage(boolean), the following line in 4=
.9
>                        List<VolumeVO> vols =3D _volsDao.listVolumesToBeDe=
stroyed(new Date(System.currentTimeMillis() - ((long) StorageCleanupDelay.v=
alue() << 10)));
>    was changed to the following in 4.10
>                        // ROOT volumes will be destroyed as part of VM cl=
eanup
>                        List<VolumeVO> vols =3D _volsDao.listNonRootVolume=
sToBeDestroyed(new Date(System.currentTimeMillis() - ((long) StorageCleanup=
Delay.value() << 10)));
>    This leads to a problem (for both managed and traditional storage) in =
the following situation:
>    For example: Let=E2=80=99s say we have a system VM running on NFS prim=
ary storage. We then put this primary storage into maintenance mode, which =
creates the system VM (with the same name) on a different primary storage (=
we do not create a new row in the cloud.vm_instance table for this VM). Whi=
le this VM works, the original root disk of the system VM remains on the or=
iginal primary storage and is not destroyed by the code in StorageManagerIm=
pl.cleanupStorage(boolean) in 4.10 because 4.10 (as shown above) only asks =
for non-root volumes to consider for deletion. In the 4.9 version of the co=
de, the original root disk is cleaned up in StorageManagerImpl.cleanupStora=
ge(boolean). The problem with 4.10 relying on a root disk always being dele=
ted when the VM it belongs to is deleted is that in a situation like this t=
hat the system VM doesn=E2=80=99t get deleted at this point =E2=80=93 it ge=
ts a new root disk that=E2=80=99s hosted by a different primary storage (so=
 now it=E2=80=99s original root disk is stranded).
>    Here is the ticket and the PR where the code change went in:
>    https://issues.apache.org/jira/browse/CLOUDSTACK-9660
>    https://github.com/apache/cloudstack/pull/1825
>    To me, this needs to be fixed before we release 4.10, so I am -1 on th=
is RC.
>    My suggestion would be to basically revert PR 1825 and to make use of =
just bits and pieces of it.
>    For example, this part should be kept:
>    -                            volService.expungeVolumeAsync(volFactory.=
getVolume(vol.getId()));
>     +                            VolumeInfo volumeInfo =3D volFactory.get=
Volume(vol.getId());
>     +                            if (volumeInfo !=3D null) {
>     +                                volService.expungeVolumeAsync(volume=
Info);
>     +                            } else {
>     +                                s_logger.debug("Volume " + vol.getUu=
id() + " is already destroyed");
>     +                            }


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)