cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-9877) remove fully cloned deleted templates from primary storage
Date Fri, 14 Apr 2017 09:55:41 GMT


ASF GitHub Bot commented on CLOUDSTACK-9877:

GitHub user DaanHoogland opened a pull request:

    CLOUDSTACK-9877 Cleanup unlinked templates

    This implements CLOUDSTACK-9877 by marking templates for gc when
    1. the template they where created with is deleted from cloudstack
    2. all vms that still use it were created as full clones

You can merge this pull request into a Git repository by running:

    $ git pull cleanup-unlinked-templates

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2044
commit 7a051b31587e43f94b49bf6f26478b33fc8c4c42
Author: Daan Hoogland <>
Date:   2017-03-23T15:45:43Z

    CE-110 move config to public fields

commit cf495adfd3fea9fc4806bb1453bbe05d2200f155
Author: Daan Hoogland <>
Date:   2017-04-14T07:33:35Z

    CE-110 remove duplicate-unused functionality

commit 5cd18ebfb61839816f827eef8b0604c052edf96d
Author: Daan Hoogland <>
Date:   2017-04-14T07:41:46Z

    CE-110 task for marking cleaning fully cloned templates
      implemented by marking them for GC


> remove fully cloned deleted templates from primary storage
> ----------------------------------------------------------
>                 Key: CLOUDSTACK-9877
>                 URL:
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: VMware
>         Environment: cloudstack with vcentre and the use of "full clones"
>            Reporter: Daan Hoogland
>            Assignee: Daan Hoogland
> After a template has been deleted from cloudstack and it has only been used with the
'vmware.create.full.clone' setting, it can be cleared from primary storage.
> test notes:
> related settings:
> vmware.full.clone.template.cleanup.period = '1' (minutes, '86400')
> vmware.create.full.clone = 'true' (boolean, 'false')
> storage.template.cleanup.enabled = 'true' (boolean, 'false')
> storage.cleanup.interval = '150' (seconds, default)
> storage.cleanup.enabled = 'true' (boolean, default)
> to test:
>     a vm can be created using the default template or any template installed for this
>         I'll call it the install-template
>     The vm should be created with a full clone of the template.
>         This can be checked in the table cloud.user_vm_clone_setting
>     The install-template should be copied to the primary store of the host it is on
>         This can be checked in the table cloud.template_spool_ref
>     delete the install-template from the system
>     after at most a minute the entries in cloud.template_spool_ref for the install-template
should have the field marked_for_gc set to '1'
>     At most a minute and a half after that the field state in the same record should
be set to 'Destroyed'
>     to double check one might go to the mount for this primary storage and seek the installpath
to make sure the disk space is actually freed.

This message was sent by Atlassian JIRA

View raw message