cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9864) cleanup stale worker VMs after job expiry time
Date Thu, 06 Apr 2017 08:29:42 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958542#comment-15958542
] 

ASF GitHub Bot commented on CLOUDSTACK-9864:
--------------------------------------------

GitHub user DaanHoogland opened a pull request:

    https://github.com/apache/cloudstack/pull/2030

    WIP: CLOUDSTACK-9864 cleanup stale worker VMs after job expiry time

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shapeblue/cloudstack snapshot-housekeeping

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/2030.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2030
    
----
commit 40869570fc510fac0d2357f272e96cd4a4518176
Author: Daan Hoogland <daan.hoogland@shapeblue.com>
Date:   2017-03-30T14:35:37Z

    CE-113 trace logging and rethrow instead of nesting CloudRuntimeException

commit 66d7d846352d52cc539b1dafb5e4d0f1620829a5
Author: Daan Hoogland <daan.hoogland@shapeblue.com>
Date:   2017-04-05T12:19:14Z

    CE-113 configure workervm gc based on job expiry

commit 996f5834e6a0a9e4dc57d436ceeb5b89e6dc9974
Author: Daan Hoogland <daan.hoogland@shapeblue.com>
Date:   2017-04-05T15:35:41Z

    CE-113 extra trace log of worker VMs

----


> cleanup stale worker VMs after job expiry time
> ----------------------------------------------
>
>                 Key: CLOUDSTACK-9864
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9864
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: VMware
>            Reporter: Daan Hoogland
>            Assignee: Daan Hoogland
>              Labels: vmware, vsphere, workers
>
> In the present code cleaning worker vms after a timeout is disabled, with the documented
reason that there is no API to query for related tasks in vcenter. ACS has an expiry time
for jobs and a cancel time for jobs.
> - Jobs that take longer then the expiry time will have their results be be neglected.
> - Jobs that are cancelled are forcibly removed after the cancellation expity time.
> Any worker remaining after expiry+cancellation will surely be stale and can be removed.
> As some administrators may not want this behaviour there will be a setting which by default
is false that will guard against cleaning stale worker VMs.
> Stale worker VMs will be cleaned after 2 * (expiry-time + cancellation-time) as a safe
margin.
> related settings:
> job.expire.minutes: 1440
> job.cancel.threshold.minutes: 60
> vmware.clean.old.worker.vms: false (new)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message