Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 33309200C32 for ; Thu, 9 Mar 2017 21:59:43 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 31C30160B5F; Thu, 9 Mar 2017 20:59:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2051C160B75 for ; Thu, 9 Mar 2017 21:59:41 +0100 (CET) Received: (qmail 80823 invoked by uid 500); 9 Mar 2017 20:59:41 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 80814 invoked by uid 500); 9 Mar 2017 20:59:41 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 80811 invoked by uid 99); 9 Mar 2017 20:59:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Mar 2017 20:59:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C451F1A7A78 for ; Thu, 9 Mar 2017 20:59:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.652 X-Spam-Level: X-Spam-Status: No, score=0.652 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id cY6VNYjZ9V9v for ; Thu, 9 Mar 2017 20:59:39 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5169E5F64B for ; Thu, 9 Mar 2017 20:59:39 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7DE2EE0596 for ; Thu, 9 Mar 2017 20:59:38 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 040DE243AA for ; Thu, 9 Mar 2017 20:59:38 +0000 (UTC) Date: Thu, 9 Mar 2017 20:59:38 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9827) Storage tags stored in multiple places MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 09 Mar 2017 20:59:43 -0000 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9827?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D15903853#comment-15903853 ]=20 ASF GitHub Bot commented on CLOUDSTACK-9827: -------------------------------------------- Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1994 =20 @nvazquez I am assuming the change needed to fix the bug is line 135 at= PrimaryDataStoreHelper.java? The other changes are regarding code conformity > Storage tags stored in multiple places > -------------------------------------- > > Key: CLOUDSTACK-9827 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-982= 7 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Components: Management Server > Affects Versions: 4.10.0.0 > Environment: N/A > Reporter: Mike Tutkowski > Assignee: Nicolas Vazquez > Priority: Blocker > Fix For: 4.10.0.0 > > > I marked this as a Blocker because it concerns me that we are not handlin= g storage tags correctly in 4.10 and, as such, VM storage might get placed = in locations that users don't want. > From e-mails I sent to dev@ (most recent to oldest): > If I add a new primary storage and give it a storage tag, the tag ends up= in storage_pool_details. > If I edit an existing storage pool=E2=80=99s storage tags, it places them= in storage_pool_tags. > ********** > I believe I have found another bug (one that we should either fix or exam= ine in detail before releasing 4.10). > It looks like we have a new table: cloud.storage_pool_tags. > The addition of this table seems to have broken the listStorageTags API c= ommand. When this command runs, it doesn=E2=80=99t pick up any storage tags= for me (and I know I have one storage tag). > This data used to be stored in the cloud.storage_pool_details table. It= =E2=80=99s good to put it in its own table, but will our upgrade process mo= ve the existing tags from storage_pool_details to storage_pool_tags? -- This message was sent by Atlassian JIRA (v6.3.15#6346)