Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Tue, 14 Mar 2017 19:14:41 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.13049101.1488934246000.18096.1489518881885@Atlassian.JIRA>
In-Reply-To: <JIRA.13049101.1488934246000@Atlassian.JIRA>
References: <JIRA.13049101.1488934246000@Atlassian.JIRA> <JIRA.13049101.1488934246891@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CLOUDSTACK-9827) Storage tags stored in
 multiple places
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 14 Mar 2017 19:14:48 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9827?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D15924827#comment-15924827 ]=20

ASF GitHub Bot commented on CLOUDSTACK-9827:
--------------------------------------------

Github user nvazquez commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1994#discussion_r106002237
 =20
    --- Diff: engine/schema/test/org/apache/cloudstack/storage/datastore/db=
/PrimaryDataStoreDaoImplTest.java ---
    @@ -0,0 +1,151 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +package org.apache.cloudstack.storage.datastore.db;
    +
    +import static org.mockito.Mockito.doReturn;
    +import static org.mockito.Mockito.verify;
    +
    +import java.util.Arrays;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +
    +import org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDaoI=
mpl.ValueType;
    +import org.junit.Before;
    +import org.junit.Test;
    +import org.junit.runner.RunWith;
    +import org.mockito.InjectMocks;
    +import org.mockito.Matchers;
    +import org.mockito.Mock;
    +import org.mockito.Spy;
    +import org.powermock.modules.junit4.PowerMockRunner;
    +
    +import com.cloud.storage.ScopeType;
    +import com.cloud.storage.dao.StoragePoolHostDao;
    +import com.cloud.storage.dao.StoragePoolTagsDao;
    +
    +import junit.framework.TestCase;
    +
    +@RunWith(PowerMockRunner.class)
    +public class PrimaryDataStoreDaoImplTest extends TestCase {
    +
    +    @Mock
    +    StoragePoolDetailsDao _detailsDao;
    +    @Mock
    +    StoragePoolHostDao _hostDao;
    +    @Mock
    +    StoragePoolTagsDao _tagsDao;
    +
    +    @Spy
    +    @InjectMocks
    +    private static PrimaryDataStoreDaoImpl primaryDataStoreDao =3D new=
 PrimaryDataStoreDaoImpl();
    +
    +    @Mock
    +    static StoragePoolVO storagePoolVO;
    --- End diff --
   =20
    Thanks! I removed it


> Storage tags stored in multiple places
> --------------------------------------
>
>                 Key: CLOUDSTACK-9827
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-982=
7
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the defa=
ult.)=20
>          Components: Management Server
>    Affects Versions: 4.10.0.0
>         Environment: N/A
>            Reporter: Mike Tutkowski
>            Assignee: Nicolas Vazquez
>            Priority: Blocker
>             Fix For: 4.10.0.0
>
>
> I marked this as a Blocker because it concerns me that we are not handlin=
g storage tags correctly in 4.10 and, as such, VM storage might get placed =
in locations that users don't want.
> From e-mails I sent to dev@ (most recent to oldest):
> If I add a new primary storage and give it a storage tag, the tag ends up=
 in storage_pool_details.
> If I edit an existing storage pool=E2=80=99s storage tags, it places them=
 in storage_pool_tags.
> **********
> I believe I have found another bug (one that we should either fix or exam=
ine in detail before releasing 4.10).
> It looks like we have a new table: cloud.storage_pool_tags.
> The addition of this table seems to have broken the listStorageTags API c=
ommand. When this command runs, it doesn=E2=80=99t pick up any storage tags=
 for me (and I know I have one storage tag).
> This data used to be stored in the cloud.storage_pool_details table. It=
=E2=80=99s good to put it in its own table, but will our upgrade process mo=
ve the existing tags from storage_pool_details to storage_pool_tags?


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)