Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Tue, 14 Mar 2017 18:35:41 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.13049101.1488934246000.17578.1489516541799@Atlassian.JIRA>
In-Reply-To: <JIRA.13049101.1488934246000@Atlassian.JIRA>
References: <JIRA.13049101.1488934246000@Atlassian.JIRA> <JIRA.13049101.1488934246891@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CLOUDSTACK-9827) Storage tags stored in
 multiple places
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 14 Mar 2017 18:35:48 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9827?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D15924759#comment-15924759 ]=20

ASF GitHub Bot commented on CLOUDSTACK-9827:
--------------------------------------------

Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1994#discussion_r105992559
 =20
    --- Diff: engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImp=
l.java ---
    @@ -77,4 +92,71 @@ public void deleteTags(long poolId) {
             txn.commit();
         }
    =20
    +    @Override
    +    public List<StoragePoolTagVO> searchByIds(Long... stIds) {
    +        final int detailsBatchSize =3D getDetailsBatchSize();
    +
    +        // query details by batches
    +        List<StoragePoolTagVO> uvList =3D new ArrayList<StoragePoolTag=
VO>();
    +        int curr_index =3D 0;
    +
    +        if (stIds.length > detailsBatchSize) {
    --- End diff --
   =20
    Correct me if I am wrong, but this `if` is not needed.
    Let's assume the configuration:
    ```
    batchSize=3D2000
    current_index=3D0
    lengthOfStIds=3D100
    ```
   =20
    `curr_index + detailsBatchSize =3D 0 + 2000`, which is not less than th=
e size of the array `(100)`. Therefore, the while is not executed. Then, th=
e pools will be loaded at lines 100-112


> Storage tags stored in multiple places
> --------------------------------------
>
>                 Key: CLOUDSTACK-9827
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-982=
7
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the defa=
ult.)=20
>          Components: Management Server
>    Affects Versions: 4.10.0.0
>         Environment: N/A
>            Reporter: Mike Tutkowski
>            Assignee: Nicolas Vazquez
>            Priority: Blocker
>             Fix For: 4.10.0.0
>
>
> I marked this as a Blocker because it concerns me that we are not handlin=
g storage tags correctly in 4.10 and, as such, VM storage might get placed =
in locations that users don't want.
> From e-mails I sent to dev@ (most recent to oldest):
> If I add a new primary storage and give it a storage tag, the tag ends up=
 in storage_pool_details.
> If I edit an existing storage pool=E2=80=99s storage tags, it places them=
 in storage_pool_tags.
> **********
> I believe I have found another bug (one that we should either fix or exam=
ine in detail before releasing 4.10).
> It looks like we have a new table: cloud.storage_pool_tags.
> The addition of this table seems to have broken the listStorageTags API c=
ommand. When this command runs, it doesn=E2=80=99t pick up any storage tags=
 for me (and I know I have one storage tag).
> This data used to be stored in the cloud.storage_pool_details table. It=
=E2=80=99s good to put it in its own table, but will our upgrade process mo=
ve the existing tags from storage_pool_details to storage_pool_tags?


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)