Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E6398200C5B for ; Wed, 15 Mar 2017 06:26:47 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E4DED160B7E; Wed, 15 Mar 2017 05:26:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3B2B9160B8C for ; Wed, 15 Mar 2017 06:26:47 +0100 (CET) Received: (qmail 38176 invoked by uid 500); 15 Mar 2017 05:26:46 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 38143 invoked by uid 500); 15 Mar 2017 05:26:46 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 38137 invoked by uid 99); 15 Mar 2017 05:26:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Mar 2017 05:26:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DBA231A0551 for ; Wed, 15 Mar 2017 05:26:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id TMf6L2C1i_g6 for ; Wed, 15 Mar 2017 05:26:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B38835FE25 for ; Wed, 15 Mar 2017 05:26:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7AF05E0A4B for ; Wed, 15 Mar 2017 05:26:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C2376243B6 for ; Wed, 15 Mar 2017 05:26:41 +0000 (UTC) Date: Wed, 15 Mar 2017 05:26:41 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-8855) Improve Error Message for Host Alert State MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 15 Mar 2017 05:26:48 -0000 [ https://issues.apache.org/jira/browse/CLOUDSTACK-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925542#comment-15925542 ] ASF GitHub Bot commented on CLOUDSTACK-8855: -------------------------------------------- Github user bvbharatk commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/837#discussion_r106088129 --- Diff: engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java --- @@ -986,33 +986,28 @@ public Answer easySend(final Long hostId, final Command cmd) { } @Override - public boolean reconnect(final long hostId) { + public void reconnect(final long hostId) throws CloudRuntimeException, AgentUnavailableException{ --- End diff -- @rafaelweingartner The reconnect method is a method in the interface AgentManager.java, This interface is also implemented by ClusteredAgentManagerImpl.java in which propagateAgentEvent method throws a AgentUnavailableException. So i had to add this to the interface and also to the implementing class method. > Improve Error Message for Host Alert State > ------------------------------------------ > > Key: CLOUDSTACK-8855 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8855 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Affects Versions: 4.6.0 > Reporter: Bharat Kumar > Assignee: Bharat Kumar > -- This message was sent by Atlassian JIRA (v6.3.15#6346)