Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Mon, 13 Mar 2017 17:08:41 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12687508.1389037400000.4674.1489424921803@Atlassian.JIRA>
In-Reply-To: <JIRA.12687508.1389037400000@Atlassian.JIRA>
References: <JIRA.12687508.1389037400000@Atlassian.JIRA> <JIRA.12687508.1389037400720@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CLOUDSTACK-5806) Storage types other than
 NFS/VMFS can't overprovision
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 13 Mar 2017 17:08:53 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907871#comment-15907871 ] 

ASF subversion and git services commented on CLOUDSTACK-5806:
-------------------------------------------------------------

Commit 9b85cbca4187f34aee52dfe5b5d02257d7dcd5e7 in cloudstack's branch refs/heads/master from [~rajanik]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9b85cbc ]

Merge pull request #1958 from shapeblue/CLOUDSTACK-5806

CLOUDSTACK-5806: add presetup to storage types that support over provisioning

Ideally this should be configurable via global settings

* pr/1958:
  CLOUDSTACK-5806: add presetup to storage types that support over provisioning Ideally this should be configurable via global settings

Signed-off-by: Rajani Karuturi <rajani.karuturi@accelerite.com>


> Storage types other than NFS/VMFS can't overprovision
> -----------------------------------------------------
>
>                 Key: CLOUDSTACK-5806
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5806
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.2.0, 4.3.0, Future
>            Reporter: Marcus Sorensen
>            Assignee: edison su
>            Priority: Critical
>             Fix For: 4.4.0
>
>
> Edison, Mike, or myself can probably fix this. Mgmt server hardcodes storage types that can overprovision. Need to fix this.
> Edison suggests:
> We can move it to storage driver's capabilities method.
> Each storage driver can report its capabilities in DataStoreDriver-> getCapabilities(), which returns a map[String, String], we can change the signature to map[String, Object]
> In CloudStackPrimaryDataStoreDriverImpl(the default storage driver)-> getCapabilities, which can return something like:
> Var comparator = new  storageOverProvision() {
>     Public Boolean isOverProvisionSupported(DataStore store) {
>        Var storagepool = (PrimaryDataStoreInfo)store;
>        If (store.getPoolType() == NFS or VMFS) {
>            Return true;
>       }
>      };
> };
> Var caps = new HashMap[String, Object]();
> Caps.put("storageOverProvision", comparator);
> Return caps;
> }
> Whenever, other places in mgt server want to check the capabilities of overprovision, we can do the following:
> Var primaryStore = DataStoreManager. getPrimaryDataStore(primaryStoreId);
> var caps = primaryStore. getDriver().getCapabilities();
> var overprovision = caps.get("storageOverProvision");
> var result = overprovision. isOverProvisionSupported(primaryStore);


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)