cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9706) Retry deleting snapshot if deleteSnapshot command failed
Date Thu, 16 Mar 2017 10:50:41 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927822#comment-15927822
] 

ASF GitHub Bot commented on CLOUDSTACK-9706:
--------------------------------------------

Github user anshul1886 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1867#discussion_r106387348
  
    --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java
---
    @@ -191,7 +191,8 @@ public void processEvent(ObjectInDataStoreStateMachine.Event event)
{
                 s_logger.debug("Failed to update state:" + e.toString());
                 throw new CloudRuntimeException("Failed to update state: " + e.toString());
             } finally {
    -            if (event == ObjectInDataStoreStateMachine.Event.OperationFailed) {
    +            DataObjectInStore obj = objectInStoreMgr.findObject(this, this.getDataStore());
    +            if (event == ObjectInDataStoreStateMachine.Event.OperationFailed &&
!obj.getState().equals(ObjectInDataStoreStateMachine.State.Destroying)) {
    --- End diff --
    
    @koushik-das obj cannot be null as that method is kind of called on that object itself.
That method is fetching it from DB for some more details. 


> Retry deleting snapshot if deleteSnapshot command failed 
> ---------------------------------------------------------
>
>                 Key: CLOUDSTACK-9706
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9706
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Anshul Gangwar
>            Assignee: Anshul Gangwar
>
> Currently when we delete snapshot then we mark it to be in destroyed state first and
then we go to delete it on storage if it can be deleted. If the deletion of snapshot fails
then we never retry to delete it which fills up storage.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message