cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-9198) VR gets created in the disabled POD
Date Tue, 14 Mar 2017 02:25:41 GMT


ASF GitHub Bot commented on CLOUDSTACK-9198:

Github user nvazquez commented on the issue:
    Hi @rafaelweingartner @anshul1886 @GabrielBrascher,
    I've read this PR's comments several times and I think I could understand @anshul1886's
point. Please correct me if I'm wrong. The execution of `getCallingAccount()` is setting the
context with the proper account, and I think that's fine, as next methods will use it (e.g.
`orchestrateStart` in `VirtualMachineManagerImpl` lines 829-831).
    I also agree with @rafaelweingartner and @GabrielBrascher that even though the context
is being set, variables `user` and `caller` on `start` method (defined on line 266) are not
being used. @anshul1886, if no validations are required and the context is already set, don't
you think that those unused parameters can be removed?

> VR gets created in the disabled POD
> -----------------------------------
>                 Key: CLOUDSTACK-9198
>                 URL:
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Anshul Gangwar
>            Assignee: Anshul Gangwar
> VR gets created in the disabled POD

This message was sent by Atlassian JIRA

View raw message