cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9198) VR gets created in the disabled POD
Date Mon, 06 Mar 2017 16:07:32 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897559#comment-15897559
] 

ASF GitHub Bot commented on CLOUDSTACK-9198:
--------------------------------------------

Github user rafaelweingartner commented on the issue:

    https://github.com/apache/cloudstack/pull/1278
  
    @anshul1886 sorry, but I still do not understand you.
    
    Your changes affect `NetworkHelperImpl.java` class. Do we agree on that?
    
    You changed lines 334 and 512. You changed the call `startVirtualRouter`; this method
is implemented in the same `NetworkHelperImpl.java` class. Before you change the call was
`startVirtualRouter(router, _accountMgr.getSystemUser(), _accountMgr.getSystemAccount(), routerDeploymentDefinition.getParams())`;
then, you altered the code to `startVirtualRouter(router, callerUser, caller, routerDeploymentDefinition.getParams())`.

    
    You changed the way the code is retrieving objects “user” and “account”; before
the user was retrieved as `_accountMgr.getSystemUser()`, now it is retrieved as `_accountMgr.getActiveUser(CallContext.current().getCallingUserId())`.
The account was obtained as `_accountMgr.getSystemAccount()` and now it is obtained as `CallContext.current().getCallingAccount()`.
    
    Can we agree on this?
    
    You are telling me to look at the Deployment planner. However, what I fail to understand
is the following.
    
    Looking at lines 334 and 512, the `user` and `account` are passed as parameters to `com.cloud.network.router.NetworkHelperImpl.startVirtualRouter(DomainRouterVO,
User, Account, Map<Param, Object>)`. This method is in the same ` NetworkHelperImpl`
class. The only thing the ` startVirtualRouter` method does with the mentioned objects is
to send them as parameters to ` com.cloud.network.router.NetworkHelperImpl.start(DomainRouterVO,
User, Account, Map<Param, Object>, DeploymentPlan)` at lines 349, 387, or 412. Then,
the method to ` com.cloud.network.router.NetworkHelperImpl.start(DomainRouterVO, User, Account,
Map<Param, Object>, DeploymentPlan)` does not use the ` User` and `Account` objects.
    
    Can we agree on that?



> VR gets created in the disabled POD
> -----------------------------------
>
>                 Key: CLOUDSTACK-9198
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9198
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Anshul Gangwar
>            Assignee: Anshul Gangwar
>
> VR gets created in the disabled POD



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message