cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8855) Improve Error Message for Host Alert State
Date Wed, 15 Mar 2017 15:02:41 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926316#comment-15926316
] 

ASF GitHub Bot commented on CLOUDSTACK-8855:
--------------------------------------------

Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/837#discussion_r106188366
  
    --- Diff: server/src/com/cloud/alert/AlertManagerImpl.java ---
    @@ -767,7 +767,9 @@ public void sendAlert(AlertType alertType, long dataCenterId, Long
podId, Long c
                     // set up a new alert
                     AlertVO newAlert = new AlertVO();
                     newAlert.setType(alertType.getType());
    -                newAlert.setSubject(subject);
    +                //do not have a seperate column for content.
    +                //appending the message to the subject for now.
    +                newAlert.setSubject(subject+content);
    --- End diff --
    
    I agree with you that we should not try to save the world in a single day. However, comments
in the code for me mean nothing (comments and documentation are two different things). ACS
has a lot of comments saying to improve this or that, and they just stay there for days, months
and years. So, adding a comment like that does not bring any value to the code. My point is
that this specific case is not a complicated one; it is only a matter of adding a column to
a table, then a new property in a POJO, and setting the correct value in the newly created
property.
    
    The same way I understand that we should not try to save the planet at once, I also have
the philosophy that we should not let to do tomorrow what can be done today.



> Improve Error Message for Host Alert State
> ------------------------------------------
>
>                 Key: CLOUDSTACK-8855
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8855
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.6.0
>            Reporter: Bharat Kumar
>            Assignee: Bharat Kumar
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message