cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8855) Improve Error Message for Host Alert State
Date Tue, 14 Mar 2017 11:20:41 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924006#comment-15924006
] 

ASF GitHub Bot commented on CLOUDSTACK-8855:
--------------------------------------------

Github user bvbharatk commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/837#discussion_r105881247
  
    --- Diff: engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
    @@ -1049,7 +1044,13 @@ public boolean executeUserRequest(final long hostId, final Event
event) throws A
                 }
                 return true;
             } else if (event == Event.ShutdownRequested) {
    -            return reconnect(hostId);
    +            //should throw a exception here as well.instead of eating this up.
    +           try {
    +               reconnect(hostId);
    +           } catch (CloudRuntimeException e) {
    --- End diff --
    
    @sureshanaparti 
    I agree with you, I have also added a comment in the code indicating the same. We can
work on it in a different pr. This is just a small improvement to the existing code. Fixing
this will need lot of rework and cause code churn. So the intention was to do this later in
a separate PR.


> Improve Error Message for Host Alert State
> ------------------------------------------
>
>                 Key: CLOUDSTACK-8855
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8855
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.6.0
>            Reporter: Bharat Kumar
>            Assignee: Bharat Kumar
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message