Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Fri, 17 Feb 2017 13:41:41 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.13043984.1487337525000.110225.1487338901818@Atlassian.JIRA>
In-Reply-To: <JIRA.13043984.1487337525000@Atlassian.JIRA>
References: <JIRA.13043984.1487337525000@Atlassian.JIRA> <JIRA.13043984.1487337525782@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CLOUDSTACK-9793) Unnecessary conversion from
 IPNetwork to list causes router slowdown when processing static Nat rules
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 17 Feb 2017 13:41:46 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871868#comment-15871868 ] 

ASF GitHub Bot commented on CLOUDSTACK-9793:
--------------------------------------------

Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1948
  
    Thanks, @ProjectMoon I cannot run tests against it since we don't have an automated way to build the systemVM. 


> Unnecessary conversion from IPNetwork to list causes router slowdown when processing static Nat rules
> -----------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9793
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9793
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Virtual Router
>    Affects Versions: 4.7.0, 4.8.0, 4.9.0
>            Reporter: Stefania Bergljot Stefansdottir
>             Fix For: 4.10.0.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> In the CsInterface class in CsAddress.py on the virtual router there's a function
> {code:java}
> def ip_in_subnet(self, ip):
>     ipo = IPAddress(ip)
>     net = IPNetwork("%s/%s" % (self.get_ip(), self.get_size()))
>     return ipo in list(net)
> {code}
> Skipping the list conversion and using "return ipo in net" is much faster and the functionality is the same. It can prevent a router timeout when attaching or detaching multiple IPs.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)