Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C7CC8200C22 for ; Tue, 7 Feb 2017 03:11:45 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C651F160B64; Tue, 7 Feb 2017 02:11:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1B12E160B56 for ; Tue, 7 Feb 2017 03:11:44 +0100 (CET) Received: (qmail 64803 invoked by uid 500); 7 Feb 2017 02:11:44 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 64794 invoked by uid 500); 7 Feb 2017 02:11:44 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 64791 invoked by uid 99); 7 Feb 2017 02:11:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Feb 2017 02:11:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A332A180031 for ; Tue, 7 Feb 2017 02:11:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 5xmm9l6ySRQU for ; Tue, 7 Feb 2017 02:11:42 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 99A1E5FB9F for ; Tue, 7 Feb 2017 02:11:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 150C4E02EF for ; Tue, 7 Feb 2017 02:11:41 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AA5A52528B for ; Tue, 7 Feb 2017 02:11:41 +0000 (UTC) Date: Tue, 7 Feb 2017 02:11:41 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9738) Optimize vm expunge process for instances with vm snapshots MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 07 Feb 2017 02:11:46 -0000 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855155#comment-15855155 ] ASF GitHub Bot commented on CLOUDSTACK-9738: -------------------------------------------- Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1905 @karuturi regarding tests done, we've compared the number of delete tasks sent to Vmware hypervisor on expunging a vm with `N` vm snapshots before and after this optimization, reducing from `N+1` tasks to only `1`. Is a marvin test required for this case? Thanks > Optimize vm expunge process for instances with vm snapshots > ----------------------------------------------------------- > > Key: CLOUDSTACK-9738 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9738 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the default.) > Affects Versions: 4.10.0.0 > Reporter: Nicolas Vazquez > Assignee: Nicolas Vazquez > Fix For: 4.10.0.0 > > > h2. Description > It was noticed that expunging instances with many vm snapshots took a look of time, as hypervisor received as many tasks as vm snapshots instance had, apart from the delete vm task. We propose a way to optimize this process for instances with vm snapshots by sending only one delete task to hypervisor, which will delete vm and its snapshots > h2. Use cases > # deleteVMsnapohsot-> no changes to current behavior > # destroyVM with expunge=false -> no actions to VMsnaphsot is performed at the moment. When VM cleanup thread is executed it will perform the same sequence as #3. If instance is recovered before expunged by the cleanup thread it will remain intact with VMSnapshot chain present > # destroyVM with expunge=true: > #* Vmsnaphsot is marked with removed timestamp and state = Expunging in DB > #* VM is deleted in HW -- This message was sent by Atlassian JIRA (v6.3.15#6346)