Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Tue, 28 Feb 2017 09:03:45 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12918699.1449205237000.16178.1488272625734@Atlassian.JIRA>
In-Reply-To: <JIRA.12918699.1449205237000@Atlassian.JIRA>
References: <JIRA.12918699.1449205237000@Atlassian.JIRA> <JIRA.12918699.1449205237882@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CLOUDSTACK-9104) VM naming convention in case
 vmware is used
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 28 Feb 2017 09:03:50 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9104?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D15887610#comment-15887610 ]=20

ASF GitHub Bot commented on CLOUDSTACK-9104:
--------------------------------------------

Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1302#discussion_r103405279
 =20
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/re=
source/VmwareResource.java ---
    @@ -2226,17 +2227,33 @@ int getReservedCpuMHZ(VirtualMachineTO vmSpec) =
{
             return new String[] {datastoreDiskPath};
         }
    =20
    -    // Pair<internal CS name, vCenter display name>
    -    private Pair<String, String> composeVmNames(VirtualMachineTO vmSpe=
c) {
    -        String vmInternalCSName =3D vmSpec.getName();
    -        String vmNameOnVcenter =3D vmSpec.getName();
    -        if (_instanceNameFlag && vmSpec.getHostName() !=3D null) {
    -            vmNameOnVcenter =3D vmSpec.getHostName();
    +    /**
    +     * This method generates VM name for Vcenter and Cloudstack( when =
Hypervisor is VMware).
    +     * It generates VM name according to  _instanceNameFlag setting.
    +     *
    +     * @param VirtualMachineTO
    +     *        vmSpec
    +     * @return Pair<internal CS name, vCenter display name>. A pair wh=
ich contain 'internal CS name'  and
    +     *         'vCenter display name'(vCenter knows VM by this name).
    +     **/
    +    protected Pair<String, String> composeVmNames(VirtualMachineTO vmS=
pec) {
    +
    +        String vmInternalCSName =3D "";
    +        String vmNameOnVcenter  =3D "";
    +        if(vmSpec !=3D null)
    +        {
    +            vmInternalCSName =3D vmNameOnVcenter =3D vmSpec.getName();
    +            if (_instanceNameFlag =3D=3D true && vmSpec.getType() =3D=
=3D VirtualMachine.Type.User) {
    +                String[] tokens =3D vmInternalCSName.split("-");
    +                if(tokens.length<3) throw new InvalidParameterValueExc=
eption("Invalid vmInternalCSName format: "+vmInternalCSName+" expected form=
at : *-*-* (e.g -> i-x-y)"); // vmInternalCSName has format i-x-y-<instance=
.name>
    +                vmNameOnVcenter =3D String.format("%s-%s-%s-%s", token=
s[0], tokens[1], tokens[2], vmSpec.getHostName());
    --- End diff --
   =20
    The token length comparison may break backward compatibility for existi=
ng VMs that may not conform to this scheme. Also, assuming the token length=
 is 3 the line can be written as:
    `vmNameOnVcenter =3D String.format("%s-%s", vmInternalCSName, vmSpec.ge=
tHostName());`
   =20
    As per previous code, `vmNameOnVcenter =3D vmSpec.getHostName()`, which=
 will introduce backward compatibility issues for older 4.3 environments. I=
s there any code that handles for such old VMs. If a 4.3 user decides to up=
grade to 4.10+, their VMs might not start the next time someone restarts. P=
lease comment on how the change addresses backward compatibility issue.


> VM naming convention in case vmware is used
> -------------------------------------------
>
>                 Key: CLOUDSTACK-9104
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-910=
4
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the defa=
ult.)=20
>            Reporter: Priyank Parihar
>            Assignee: Priyank Parihar
>
> ISSUE
> =3D=3D=3D=3D=3D=3D
> VM naming convention in case vmware is used.
> Description
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> User with different account cannot create VMs with the same name, which w=
as possible earlier (I am not sure in which CCP version). That time naming =
convention used was like this =E2=80=9CI-<user-id>-<Display-Name>=E2=80=9D
> Currently if vm.instancename.flag is set to true the VM name will be exac=
tly as display name given.=20


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)