Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3086B200C23 for ; Wed, 22 Feb 2017 10:26:51 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 2F391160B67; Wed, 22 Feb 2017 09:26:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 79902160B49 for ; Wed, 22 Feb 2017 10:26:50 +0100 (CET) Received: (qmail 85920 invoked by uid 500); 22 Feb 2017 09:26:49 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 85911 invoked by uid 500); 22 Feb 2017 09:26:49 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 85908 invoked by uid 99); 22 Feb 2017 09:26:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Feb 2017 09:26:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1A8FD1A57A1 for ; Wed, 22 Feb 2017 09:26:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.198 X-Spam-Level: X-Spam-Status: No, score=-1.198 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id OOLpYCAm5vxI for ; Wed, 22 Feb 2017 09:26:48 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 289915F56B for ; Wed, 22 Feb 2017 09:26:48 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 77941E05EE for ; Wed, 22 Feb 2017 09:26:44 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 342D924123 for ; Wed, 22 Feb 2017 09:26:44 +0000 (UTC) Date: Wed, 22 Feb 2017 09:26:44 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-5806) Storage types other than NFS/VMFS can't overprovision MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 22 Feb 2017 09:26:51 -0000 [ https://issues.apache.org/jira/browse/CLOUDSTACK-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877844#comment-15877844 ] ASF GitHub Bot commented on CLOUDSTACK-5806: -------------------------------------------- Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1958 @blueorangutan test > Storage types other than NFS/VMFS can't overprovision > ----------------------------------------------------- > > Key: CLOUDSTACK-5806 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5806 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Components: Management Server > Affects Versions: 4.2.0, 4.3.0, Future > Reporter: Marcus Sorensen > Assignee: edison su > Priority: Critical > Fix For: 4.4.0 > > > Edison, Mike, or myself can probably fix this. Mgmt server hardcodes storage types that can overprovision. Need to fix this. > Edison suggests: > We can move it to storage driver's capabilities method. > Each storage driver can report its capabilities in DataStoreDriver-> getCapabilities(), which returns a map[String, String], we can change the signature to map[String, Object] > In CloudStackPrimaryDataStoreDriverImpl(the default storage driver)-> getCapabilities, which can return something like: > Var comparator = new storageOverProvision() { > Public Boolean isOverProvisionSupported(DataStore store) { > Var storagepool = (PrimaryDataStoreInfo)store; > If (store.getPoolType() == NFS or VMFS) { > Return true; > } > }; > }; > Var caps = new HashMap[String, Object](); > Caps.put("storageOverProvision", comparator); > Return caps; > } > Whenever, other places in mgt server want to check the capabilities of overprovision, we can do the following: > Var primaryStore = DataStoreManager. getPrimaryDataStore(primaryStoreId); > var caps = primaryStore. getDriver().getCapabilities(); > var overprovision = caps.get("storageOverProvision"); > var result = overprovision. isOverProvisionSupported(primaryStore); -- This message was sent by Atlassian JIRA (v6.3.15#6346)