cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9794) Unable to attach more than 14 devices to a VM
Date Tue, 21 Feb 2017 11:41:44 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875849#comment-15875849
] 

ASF GitHub Bot commented on CLOUDSTACK-9794:
--------------------------------------------

Github user HrWiggles commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1953#discussion_r102181285
  
    --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
    @@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm) {
             return maxDataVolumesSupported.intValue();
         }
     
    -    private Long getDeviceId(long vmId, Long deviceId) {
    +    private Long getDeviceId(UserVmVO vm, Long deviceId) {
             // allocate deviceId
    -        List<VolumeVO> vols = _volsDao.findByInstance(vmId);
    +        int maxDataVolumesSupported = getMaxDataVolumesSupported(vm);
    +        List<VolumeVO> vols = _volsDao.findByInstance(vm.getId());
             if (deviceId != null) {
    -            if (deviceId.longValue() > 15 || deviceId.longValue() == 3) {
    -                throw new RuntimeException("deviceId should be 1,2,4-15");
    +            if (deviceId.longValue() > maxDataVolumesSupported || deviceId.longValue()
== 3) {
    +                throw new RuntimeException("deviceId should be 1,2,4-" + maxDataVolumesSupported);
                 }
                 for (VolumeVO vol : vols) {
                     if (vol.getDeviceId().equals(deviceId)) {
    -                    throw new RuntimeException("deviceId " + deviceId + " is used by
vm" + vmId);
    +                    throw new RuntimeException("deviceId " + deviceId + " is used by
vm" + vm.getId());
                     }
                 }
             } else {
                 // allocate deviceId here
                 List<String> devIds = new ArrayList<String>();
    -            for (int i = 1; i < 15; i++) {
    +            for (int i = 1; i < maxDataVolumesSupported; i++) {
                     devIds.add(String.valueOf(i));
                 }
                 devIds.remove("3");
    --- End diff --
    
    Not part of your changes but... there's a possible `NoSuchElementException` below, for
line:
    ```
    deviceId = Long.parseLong(devIds.iterator().next());
    ```
    A check should be added for whether `devIds` is empty and, if so, throw a `RuntimeException`
with an error message which specifies that all possible device ids are already in use by the
vm (if only to be consistent with the rest of the method).


> Unable to attach more than 14 devices to a VM
> ---------------------------------------------
>
>                 Key: CLOUDSTACK-9794
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9794
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Volumes
>            Reporter: Suresh Kumar Anaparti
>            Assignee: Suresh Kumar Anaparti
>             Fix For: 4.10
>
>
> A limit of 13 disks is set in hypervisor_capabilities for VMware hypervisor. Changed
this limit to a higher value in the DB directly for the VMware and tried attaching more than
14 disks. This was failing with the below exception:
> {noformat}
> 2016-08-12 18:42:53,694 ERROR [c.c.a.ApiAsyncJobDispatcher] (API-Job-Executor-40:ctx-56068c6b
job-1015) (logid:b22938fd) Unexpected exception while executing org.apache.cloudstack.api.command.admin.volume.AttachVolumeCmdByAdmin
> java.util.NoSuchElementException
> 	at java.util.ArrayList$Itr.next(ArrayList.java:794)
> 	at com.cloud.storage.VolumeApiServiceImpl.getDeviceId(VolumeApiServiceImpl.java:2439)
> 	at com.cloud.storage.VolumeApiServiceImpl.attachVolumeToVM(VolumeApiServiceImpl.java:1308)
> 	at com.cloud.storage.VolumeApiServiceImpl.attachVolumeToVM(VolumeApiServiceImpl.java:1173)
> 	at sun.reflect.GeneratedMethodAccessor248.invoke(Unknown Source)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:601)
> 	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
> 	at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
> 	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
> 	at org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:106)
> {noformat}
> There was a hardcoded limit of 15 on the number of devices for a VM.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message