cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9772) Perform HEAD request to retrieve header information
Date Sun, 12 Feb 2017 20:10:42 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862946#comment-15862946
] 

ASF GitHub Bot commented on CLOUDSTACK-9772:
--------------------------------------------

Github user remibergsma commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1934#discussion_r100702832
  
    --- Diff: utils/src/main/java/com/cloud/utils/UriUtils.java ---
    @@ -200,37 +198,27 @@ public static String getUpdateUri(String url, boolean encrypt) {
         }
     
         // Get the size of a file from URL response header.
    -    public static Long getRemoteSize(String url) {
    -        Long remoteSize = (long)0;
    +    public static long getRemoteSize(String url) {
    --- End diff --
    
    @marcaurele I think this needs to be changed back to Long, or else the method cannot be
found as it is called with type Long.


> Perform HEAD request to retrieve header information
> ---------------------------------------------------
>
>                 Key: CLOUDSTACK-9772
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9772
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Template
>    Affects Versions: 4.2.0, 4.2.1, 4.3.0, 4.4.0, 4.5.0, 4.3.1, 4.4.1, 4.4.2, 4.4.3, 4.3.2,
4.5.1, 4.4.4, 4.5.2, 4.6.0, 4.6.1, 4.6.2, 4.7.0, 4.7.1, 4.8.0, 4.9.0, 4.8.1.1, 4.9.0.1, 4.5.2.2
>            Reporter: Marc-Aurèle Brothier
>            Assignee: Marc-Aurèle Brothier
>
> The function in UriUtils which perform a check for the template file size of an arbitrary
URL is sending a `GET` request to only retrieve the response header. A `HEAD` is the correct
way of retrieving such information from the response header.
> This was affecting the restart of a management server since all templates were retrieved
when receiving the startup command from the secondary storage sysvm.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message