cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-8239) Add support for VirtIO-SCSI for KVM hypervisors
Date Thu, 23 Feb 2017 10:52:44 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880251#comment-15880251
] 

ASF GitHub Bot commented on CLOUDSTACK-8239:
--------------------------------------------

Github user wido commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1955#discussion_r102687039
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
    @@ -2059,6 +2060,13 @@ So if getMinSpeed() returns null we fall back to getSpeed().
             final InputDef input = new InputDef("tablet", "usb");
             devices.addDevice(input);
     
    +        // If we're using virtio scsi, then we need to add a virtual scsi controller
    +        if (getGuestDiskModel(vmTO.getPlatformEmulator()) == DiskDef.DiskBus.SCSI) {
    +            final SCSIDef sd = new SCSIDef((short)0, 0, 0, 9, 0);
    +            devices.addDevice(sd);
    +            s_logger.debug("Adding scsi definition:\n" + sd.toString());
    --- End diff --
    
    Might want to include the name of the VM here as well? And SCSI is written in upper-case.


> Add support for VirtIO-SCSI for KVM hypervisors
> -----------------------------------------------
>
>                 Key: CLOUDSTACK-8239
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8239
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: KVM, Storage Controller
>    Affects Versions: 4.6.0
>         Environment: KVM
>            Reporter: Andrei Mikhailovsky
>            Assignee: Wido den Hollander
>            Priority: Critical
>              Labels: ceph, gsoc2017, kvm, libvirt, rbd, storage_drivers, virtio
>             Fix For: Future
>
>
> It would be nice to have support for virtio-scsi for KVM hypervisors.
> The reason for using virtio-scsi instead of virtio-blk would be increasing the number
of devices you can attach to a vm, have ability to use discard and reclaim unused blocks from
the backend storage like ceph rbd. There are also talks about having a greater performance
advantage as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message