Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Tue, 24 Jan 2017 19:17:26 +0000 (UTC)
From: "rashmidixit (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12998436.1471596971000.191369.1485285446437@Atlassian.JIRA>
In-Reply-To: <JIRA.12998436.1471596971000@Atlassian.JIRA>
References: <JIRA.12998436.1471596971000@Atlassian.JIRA> <JIRA.12998436.1471596971584@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CLOUDSTACK-9462) Systemd packaging for Ubuntu
 16.04
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 24 Jan 2017 19:17:31 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836475#comment-15836475 ] 

rashmidixit commented on CLOUDSTACK-9462:
-----------------------------------------

Github user wido commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1916#discussion_r97613140
  
    --- Diff: debian/cloudstack-management.postinst ---
    @@ -60,7 +60,26 @@ if [ "$1" = configure ]; then
     
         chmod 0640 ${CONFDIR}/${DBPROPS}
         chgrp cloud ${CONFDIR}/${DBPROPS}
    -    invoke-rc.d tomcat6 stop || true
    +
    +    if [ -d "/usr/share/tomcat7" ]; then
    +        rm -f /usr/share/cloudstack-management/bin
    +        rm -f /usr/share/cloudstack-management/lib
    +        ln -s /usr/share/tomcat7/bin /usr/share/cloudstack-management/bin
    +        ln -s /usr/share/tomcat7/lib /usr/share/cloudstack-management/lib
    +        invoke-rc.d tomcat7 stop || true
    +        if [ ! -f "/etc/cloudstack/management/server.xml" ]; then
    +            ln -s /etc/cloudstack/management/server7-nonssl.xml /etc/cloudstack/management/server.xml
    +        fi
    +    elif [ -d "/usr/share/tomcat6" ]; then
    +        rm -f /usr/share/cloudstack-management/bin
    +        rm -f /usr/share/cloudstack-management/lib
    +        ln -s /usr/share/tomcat6/bin /usr/share/cloudstack-management/bin
    +        ln -s /usr/share/tomcat6/lib /usr/share/cloudstack-management/lib
    +        invoke-rc.d tomcat6 stop || true
    +        if [ ! -f "/etc/cloudstack/management/server.xml" ]; then
    +            ln -s /etc/cloudstack/management/server-nonssl.xml /etc/cloudstack/management/server.xml
    +        fi
    +    fi
    --- End diff --
    
    Not sure if we this is the best way. Usually creating directories and moving symlinks is not the way to go in postinst files.
    
    When cleaning packages or upgrading this might break things. Can you think of a different way?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---


> Systemd packaging for Ubuntu 16.04
> ----------------------------------
>
>                 Key: CLOUDSTACK-9462
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9462
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>             Fix For: 4.10.0.0, 4.9.1.0
>
>
> Support for building deb packages that will work on Ubuntu 16.04


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)