cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9743) ODL plugin responds to deleteHost causing other plugin in the chain to be ignored
Date Mon, 16 Jan 2017 16:32:26 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15824232#comment-15824232
] 

ASF GitHub Bot commented on CLOUDSTACK-9743:
--------------------------------------------

GitHub user syed opened a pull request:

    https://github.com/apache/cloudstack/pull/1906

    CLOUDSTACK-9743 - ODL plugin responds to deleteHost causing other plugin in the chain
to be ignored 

    I found this bug when writing a plugin for Baremetal. What happens is that when a host
is deleted, it goes through a list of all registered plugins and calls the deleteHost for
each plugin. See `ResourceManagerImpl.java:dispatchToStateAdapters` and it stops as soon as
someone returns a deleteAnswer. 
    
    Now in case of ODL, it returns a valid answer irrespective of any condition. This causes
the other plugins which are supposed to handle this delete request to be skipped. I am returning
`null` here so that Cloudstack will continue further and keep calling other agents which can
correctly handle the delete request. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/syed/cloudstack odl-deletehost-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1906.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1906
    
----
commit d7b0c728f0e6dfc5b418260674ec2b735f921c45
Author: Syed <syed1.mushtaq@gmail.com>
Date:   2016-12-14T16:38:34Z

    CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

commit 04c2007d27ed0c01bcb4dc93ec3a803ec2f7186a
Author: Syed <syed1.mushtaq@gmail.com>
Date:   2017-01-13T16:39:50Z

    Merge branch 'master' of https://github.com/apache/cloudstack

commit 2ebc32ae2c426b46c5b1e416597317678e1fb9bc
Author: Syed <syed1.mushtaq@gmail.com>
Date:   2017-01-16T16:25:15Z

    Return null when deleting host in ODL

----


> ODL plugin responds to deleteHost causing other plugin in the chain to be ignored
> ---------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9743
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9743
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: cloudstack-agent, Network Controller
>            Reporter: Syed Ahmed
>
> ODL plugin responds to deleteHost causing other plugin in the chain to be ignored



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message