cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9570) Bug in listSnapshots for snapshots with deleted data stores
Date Wed, 11 Jan 2017 01:41:58 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816793#comment-15816793
] 

ASF GitHub Bot commented on CLOUDSTACK-9570:
--------------------------------------------

Github user serg38 commented on the issue:

    https://github.com/apache/cloudstack/pull/1735
  
    @mike-tutkowski The only comments in this PR are about deletion of PS with a snapshot
copy. I am 100% agree with your statement. This PR excludes destroyed snapshot copies including
ones on the PS from evaluation during the listSnaphsot call thus avoiding NPE if original
PS is already deleted.
    Did you have other suggestions for this PR?


> Bug in listSnapshots for snapshots with deleted data stores
> -----------------------------------------------------------
>
>                 Key: CLOUDSTACK-9570
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9570
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>            Reporter: Nicolas Vazquez
>            Assignee: Nicolas Vazquez
>
> h3. Actual behaviour
> If there is snapshot on a data store that is removed, {{listSnapshots}} still tries to
enumerate it and gives error (in this example data store 2 has been removed):
> {code:xml|title=/client/api?command=listSnapshots&isrecursive=true&listall=true|borderStyle=solid}
> <listsnapshotsresponse cloud-stack-version="4.9.1.0-SNAPSHOT">
>    <errorcode>530</errorcode>
>    <cserrorcode>4250</cserrorcode>
>    <errortext>Unable to locate datastore with id 2</errortext>
> </listsnapshotsresponse>
> {code}
> h3. Reproduce error
> This steps can be followed to reproduce issue:
> * Take a snapshot of a volume (this creates a references for primary storage and secondary
storage in snapshot_store_ref table
> * Simulate retiring primary data storage where snapshot is cached (in this example X
is a fake data store and Y is snapshot id):
> {{UPDATE `cloud`.`snapshot_store_ref` SET `store_id`='X', `state`="Destroyed" WHERE `id`='Y';}}
> * List snapshots
> {{/client/api?command=listSnapshots&isrecursive=true&listall=true}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message