Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Fri, 30 Dec 2016 09:48:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.13030386.1482503262000.618035.1483091338543@Atlassian.JIRA>
In-Reply-To: <JIRA.13030386.1482503262000@Atlassian.JIRA>
References: <JIRA.13030386.1482503262000@Atlassian.JIRA> <JIRA.13030386.1482503262648@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9704) Remove dependency on
 VmwareContext object to fetch system VM key file
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 30 Dec 2016 09:49:00 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15787344#comment-15787344 ] 

ASF GitHub Bot commented on CLOUDSTACK-9704:
--------------------------------------------

Github user sureshanaparti commented on the issue:

    https://github.com/apache/cloudstack/pull/1862
  
    @sateesh-chodapuneedi Code changes LGTM


> Remove dependency on VmwareContext object to fetch system VM key file
> ---------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9704
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9704
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Sateesh Chodapuneedi
>            Assignee: Sateesh Chodapuneedi
>
> While remote executing commands/scripts in VR, ACS uses system vm keyfile. ACS is fetching this key file using following code
> {code:java}
> VmwareManager mgr = getServiceContext().getStockObject(VmwareManager.CONTEXT_STOCK_NAME);
> File systemVmKeyFile = mgr.getSystemVMKeyFile();
> {code}
> This is inefficient because dependency on getServiceContext() in above code means a vCenter connection handle which is not required just to fetch a file in name space in management server.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)