Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 62084200BD3 for ; Tue, 6 Dec 2016 07:28:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 60BA9160B1B; Tue, 6 Dec 2016 06:28:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B046D160B29 for ; Tue, 6 Dec 2016 07:28:00 +0100 (CET) Received: (qmail 77548 invoked by uid 500); 6 Dec 2016 06:27:59 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 77173 invoked by uid 500); 6 Dec 2016 06:27:58 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 77166 invoked by uid 99); 6 Dec 2016 06:27:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Dec 2016 06:27:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id B8C3A2C2AB7 for ; Tue, 6 Dec 2016 06:27:58 +0000 (UTC) Date: Tue, 6 Dec 2016 06:27:58 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9564) Fix memory leak in VmwareContextPool MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 06 Dec 2016 06:28:01 -0000 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15724568#comment-15724568 ] ASF subversion and git services commented on CLOUDSTACK-9564: ------------------------------------------------------------- Commit 8d506a624bbb8cf7fdc1fcd381551f319a90a810 in cloudstack's branch refs/heads/4.9 from [~rohit.yadav@shapeblue.com] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8d506a6 ] Merge pull request #1816 from shapeblue/4.9-fix-npe-vmware CLOUDSTACK-9564: Fix NPE due to intermittent test assertionThe test assertion on a pool object may return a null object, as objects can be randomly expired/tombstoned. This will fix a NPE sometimes seen due to recently merge for the fix for CLOUDSTACK-9564. (we can merge this if Travis passes) /cc @abhinandanprateek @murali-reddy * pr/1816: CLOUDSTACK-9564: Fix NPE due to intermittent test assertion Signed-off-by: Rohit Yadav > Fix memory leak in VmwareContextPool > ------------------------------------ > > Key: CLOUDSTACK-9564 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9564 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Reporter: Rohit Yadav > Assignee: Rohit Yadav > > In a recent management server crash, it was found that the largest contributor to memory leak was in VmwareContextPool where a registry is held (arraylist) that grows indefinitely. The list itself is not used anywhere or consumed. There exists a hashmap (pool) that returns a list of contexts for existing poolkey (address/username) that is used instead. The fix would be to get rid of the registry and limit the hashmap context list length for any poolkey. -- This message was sent by Atlassian JIRA (v6.3.4#6332)