cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-9698) Make the wait timeout for NIC adapter hotplug as configurable
Date Fri, 30 Dec 2016 07:12:58 GMT


ASF GitHub Bot commented on CLOUDSTACK-9698:

Github user koushik-das commented on a diff in the pull request:
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/
    @@ -839,7 +840,12 @@ private int findRouterEthDeviceIndex(String domrName, String routerIp,
String ma
             // when we dynamically plug in a new NIC into virtual router, it may take time
to show up in guest OS
             // we use a waiting loop here as a workaround to synchronize activities in systems
             long startTick = System.currentTimeMillis();
    -        while (System.currentTimeMillis() - startTick < 15000) {
    +        long waitTimeoutMillis = 15000;
    +        Long waitTimeoutMillisLong = VmwareManagerImpl.s_vmwareNicHotplugWaitTimeout.value();
    +        if (waitTimeoutMillisLong != null) {
    +            waitTimeoutMillis = waitTimeoutMillisLong;
    +        }
    +        while (System.currentTimeMillis() - startTick < waitTimeoutMillis) {
    --- End diff --
    The config value can be directly read using s_vmwareNicHotplugWaitTimeout.value(), no
need for the checks.

> Make the wait timeout for NIC adapter hotplug as configurable
> -------------------------------------------------------------
>                 Key: CLOUDSTACK-9698
>                 URL:
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: VMware
>    Affects Versions:
>         Environment: ACS 4.9 branch commit a0e36b73aebe43bfe6bec3ef8f53e8cb99ecbc32
> vSphere 5.5
>            Reporter: Sateesh Chodapuneedi
>            Assignee: Sateesh Chodapuneedi
>             Fix For:
> Currently ACS waits for 15 seconds (*hard coded*) for hot-plugged NIC in VR to get detected
by guest OS. The time taken to detect hot plugged NIC in guest OS depends on type of NIC adapter
like (E1000, VMXNET3, E1000e etc.) and guest OS itself. In uncommon scenarios the NIC detection
may take longer time than 15 seconds, in such cases NIC hotplug would be treated as failure
which results in VPC tier configuration failure. Making the wait timeout for NIC adapter hotplug
as configurable will be helpful for admins in such scenarios. 
> Also in future if VMware introduces new NIC adapter types which may take time to get
detected by guest OS, it is good to have flexibility of configuring the wait timeout.

This message was sent by Atlassian JIRA

View raw message