cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9698) Make the wait timeout for NIC adapter hotplug as configurable
Date Fri, 23 Dec 2016 13:41:58 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15772926#comment-15772926
] 

ASF GitHub Bot commented on CLOUDSTACK-9698:
--------------------------------------------

GitHub user sateesh-chodapuneedi opened a pull request:

    https://github.com/apache/cloudstack/pull/1861

    CLOUDSTACK-9698 Make hardcorded wait timeout for NIC adapter hotplug as configurable

    Jira
    ===
    CLOUDSTACK-9698 Make hardcoded wait timeout for NIC adapter hotplug as configurable
    
    Description
    =========
    Currently ACS waits for 15 seconds (hard coded) for hot-plugged NIC in VR to get detected
by guest OS.
    The time taken to detect hot plugged NIC in guest OS depends on type of NIC adapter like
(E1000, VMXNET3, E1000e etc.)
    and guest OS itself. In uncommon scenarios the NIC detection may take longer time than
15 seconds,
    in such cases NIC hotplug would be treated as failure which results in VPC tier configuration
failure.
    Alternatively making the wait timeout for NIC adapter hotplug as configurable will be
helpful for admins in such scenarios.
    
    Also in future if VMware introduces new NIC adapter types which may take time to get detected
by guest OS, it is good to have flexibility of
    configuring the wait timeout as fallback mechanism in such scenarios.
    
    Fix
    ===
    Introduce new configuration parameter (via ConfigKey) "vmware.nic.hotplug.wait.timeout"
which is "Wait timeout (milli seconds) for hot plugged NIC of VM to be detected by guest OS."
as fallback instead of hard coded timeout, to ensure flexibility for admins given the listed
scenarios above.
    
    Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapuneedi@accelerite.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sateesh-chodapuneedi/cloudstack pr-cloudstack-9698

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1861.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1861
    
----
commit 2ea7aadbac386f4d3a0e0062e1042e4266c24e91
Author: Sateesh Chodapuneedi <sateesh.chodapuneedi@accelerite.com>
Date:   2016-12-23T00:51:04Z

    CLOUDSTACK-9698 Make the wait timeout for NIC adapter hotplug as configurable
    
    Currently ACS waits for 15 seconds (hard coded) for hot-plugged NIC in VR to get detected
by guest OS.
    The time taken to detect hot plugged NIC in guest OS depends on type of NIC adapter like
(E1000, VMXNET3, E1000e etc.)
    and guest OS itself. In uncommon scenarios the NIC detection may take longer time than
15 seconds,
    in such cases NIC hotplug would be treated as failure which results in VPC tier configuration
failure.
    Alternatively making the wait timeout for NIC adapter hotplug as configurable will be
helpful for admins in such scenarios.
    
    Also in future if VMware introduces new NIC adapter types which may take time to get detected
by guest OS, it is good to have flexibility of
    configuring the wait timeout as fallback mechanism in such scenarios.
    
    Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapuneedi@accelerite.com>

----


> Make the wait timeout for NIC adapter hotplug as configurable
> -------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9698
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9698
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: VMware
>    Affects Versions: 4.9.0.1
>         Environment: ACS 4.9 branch commit a0e36b73aebe43bfe6bec3ef8f53e8cb99ecbc32
> vSphere 5.5
>            Reporter: Sateesh Chodapuneedi
>            Assignee: Sateesh Chodapuneedi
>             Fix For: 4.9.1.0
>
>
> Currently ACS waits for 15 seconds (*hard coded*) for hot-plugged NIC in VR to get detected
by guest OS. The time taken to detect hot plugged NIC in guest OS depends on type of NIC adapter
like (E1000, VMXNET3, E1000e etc.) and guest OS itself. In uncommon scenarios the NIC detection
may take longer time than 15 seconds, in such cases NIC hotplug would be treated as failure
which results in VPC tier configuration failure. Making the wait timeout for NIC adapter hotplug
as configurable will be helpful for admins in such scenarios. 
> Also in future if VMware introduces new NIC adapter types which may take time to get
detected by guest OS, it is good to have flexibility of configuring the wait timeout.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message