Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DC425200BD0 for ; Wed, 30 Nov 2016 23:39:52 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DAC9F160B13; Wed, 30 Nov 2016 22:39:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 305B0160B06 for ; Wed, 30 Nov 2016 23:39:52 +0100 (CET) Received: (qmail 3227 invoked by uid 500); 30 Nov 2016 22:38:00 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 3036 invoked by uid 500); 30 Nov 2016 22:37:59 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 2988 invoked by uid 99); 30 Nov 2016 22:37:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Nov 2016 22:37:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id DA7502C1F54 for ; Wed, 30 Nov 2016 22:37:59 +0000 (UTC) Date: Wed, 30 Nov 2016 22:37:59 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9632) Upgrade bountycastle to 1.55+ MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 30 Nov 2016 22:39:53 -0000 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710045#comment-15710045 ] ASF GitHub Bot commented on CLOUDSTACK-9632: -------------------------------------------- Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1799#discussion_r90314765 --- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java --- @@ -176,18 +176,18 @@ public void runUploadSslCertSelfSignedWithPassword() throws Exception { when(certService._accountDao.findByIdIncludingRemoved(anyLong())).thenReturn((AccountVO)account); //creating the command - UploadSslCertCmd uploadCmd = new UploadSslCertCmdExtn(); - Class _class = uploadCmd.getClass().getSuperclass(); + final UploadSslCertCmd uploadCmd = new UploadSslCertCmdExtn(); + final Class klazz = uploadCmd.getClass().getSuperclass(); - Field certField = _class.getDeclaredField("cert"); + final Field certField = klazz.getDeclaredField("cert"); certField.setAccessible(true); certField.set(uploadCmd, cert); - Field keyField = _class.getDeclaredField("key"); + final Field keyField = klazz.getDeclaredField("key"); keyField.setAccessible(true); keyField.set(uploadCmd, key); - Field passField = _class.getDeclaredField("password"); + final Field passField = klazz.getDeclaredField("password"); passField.setAccessible(true); passField.set(uploadCmd, password); --- End diff -- This method has not assertions to verify the correctness of `certService.uploadSslCert`. Please consider adding such assertions. > Upgrade bountycastle to 1.55+ > ----------------------------- > > Key: CLOUDSTACK-9632 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9632 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Reporter: Rohit Yadav > Assignee: Rohit Yadav > Fix For: Future, 4.10.0.0 > > > Upgrade bountycastle library to latest versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)