Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Thu, 17 Nov 2016 11:16:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.13020035.1478848130000.302752.1479381418465@Atlassian.JIRA>
In-Reply-To: <JIRA.13020035.1478848130000@Atlassian.JIRA>
References: <JIRA.13020035.1478848130000@Atlassian.JIRA> <JIRA.13020035.1478848130122@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9592) Empty responses from site to
 site connection status are not handled propertly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 17 Nov 2016 11:17:00 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15673435#comment-15673435 ] 

ASF GitHub Bot commented on CLOUDSTACK-9592:
--------------------------------------------

Github user yvsubhash commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1761#discussion_r88432900
  
    --- Diff: core/src/com/cloud/agent/api/CheckS2SVpnConnectionsAnswer.java ---
    @@ -76,4 +76,14 @@ public String getDetail(String ip) {
             }
             return null;
         }
    +
    +    public boolean isIPPresent(String ip) {
    +        if (this.getResult()) {
    +            Boolean status = ipToConnected.get(ip);
    +            if (status != null) {
    --- End diff --
    
    @jburwell  VirtualNetworkApplianceManagerImplTest.java has all tests commented out. are there any other place having tests covering this?


> Empty responses from site to site connection status are not handled propertly
> -----------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9592
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9592
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Network Controller
>    Affects Versions: 4.8.0
>         Environment: Any Hypervisor
>            Reporter: subhash yedugundla
>             Fix For: 4.8.1
>
>
> vpn connection status gives responses like the below sometimes
> Processing: { Ans: , MgmtId: 7203499016310, via: 1(10.147.28.37), Ver: v1, Flags: 110, [{"com.cloud.agent.api.CheckS2SVpnConnectionsAnswer":{"ipToConnected":{},"ipToDetail":{},"details":"","result":true,"wait":0}}] }
> 2016-09-27 08:52:19,211 DEBUG [c.c.a.t.Request] (RouterStatusMonitor-1:ctx-c20f391d) (logid:c217239d) Seq 1-2315413158421863581: Received: { Ans: , MgmtId: 7203499016310, via: 1(10.147.28.37), Ver: v1, Flags: 110,
> { CheckS2SVpnConnectionsAnswer }
> In the above scenario, the bug in the processing of this response assumes the connection is disconnected even though it is not disconnected and there would be two consecutive alerts in logs as well as emails even though there is not actual disconnection and reconnection
> Site-to-site Vpn Connection XYZ-VPN on router r-197-VM(id: 197) just switch from Disconnected to Connected
> Site-to-site Vpn Connection to D1 site to site VPN on router r-372-VM(id: 372) just switch from Connected to Disconnected


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)