Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 05D29200BC5 for ; Tue, 22 Nov 2016 07:47:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 049FD160B1C; Tue, 22 Nov 2016 06:47:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 585DA160B0A for ; Tue, 22 Nov 2016 07:46:59 +0100 (CET) Received: (qmail 70149 invoked by uid 500); 22 Nov 2016 06:46:58 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 70125 invoked by uid 500); 22 Nov 2016 06:46:58 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 70120 invoked by uid 99); 22 Nov 2016 06:46:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Nov 2016 06:46:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 5AEB32C4C70 for ; Tue, 22 Nov 2016 06:46:58 +0000 (UTC) Date: Tue, 22 Nov 2016 06:46:58 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9539) Support changing Service offering for instance with VM Snapshots MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 22 Nov 2016 06:47:00 -0000 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685881#comment-15685881 ] ASF GitHub Bot commented on CLOUDSTACK-9539: -------------------------------------------- Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1727 What about custom offerings? In case of custom offerings the cpu/ram are stored in the VM details table? How will this case be handled? > Support changing Service offering for instance with VM Snapshots > ---------------------------------------------------------------- > > Key: CLOUDSTACK-9539 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9539 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Reporter: Nicolas Vazquez > Assignee: Nicolas Vazquez > > h3. Actual behaviour > CloudStack doesn't support changing service offering for vm instances which have vm snapshots, they should be removed before changing service offering. > h3. Goal > Extend actual behaviour by supporting changing service offering for vms which have vm snapshots. In that case, previously taken snapshots (if reverted) should use previous service offering, future snapshots should use the newest. > h3. Proposed solution: > 1. Adding {{service_offering_id}} column on {{vm_snapshots}} table: This way snapshot can be reverted to original state even though service offering can be changed for vm instance. > NOTE: Existing vm snapshots are populated on update script by {{UPDATE vm_snapshots s JOIN vm_instance v ON v.id = s.vm_id SET s.service_offering_id = v.service_offering_id;}} > 2. New vm snapshots will use instance vm service offering id as {{service_offering_id}} > 3. Revert to vm snapshots should use vm snapshot's {{service_offering_id}} value. > h3. Example use case: > - Deploy vm using service offering A > - Take vm snapshot -> snap1 (service offering A) > - Stop vm > - Change vm service offering to B > - Revert to VM snapshot snap 1 > - Start vm > It is expected that vm has service offering A after last step -- This message was sent by Atlassian JIRA (v6.3.4#6332)