cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9632) Upgrade bountycastle to 1.55+
Date Wed, 30 Nov 2016 22:38:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710056#comment-15710056
] 

ASF GitHub Bot commented on CLOUDSTACK-9632:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1799#discussion_r90315713
  
    --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java ---
    @@ -180,16 +185,16 @@ public void deleteSslCert(DeleteSslCertCmd deleteSslCertCmd) {
         }
     
         @Override
    -    public List<SslCertResponse> listSslCerts(ListSslCertsCmd listSslCertCmd) {
    -        CallContext ctx = CallContext.current();
    -        Account caller = ctx.getCallingAccount();
    +    public List<SslCertResponse> listSslCerts(final ListSslCertsCmd listSslCertCmd)
{
    --- End diff --
    
    Please consider adding a `Preconditions.checkArgument` check to verify that `listSslCertCmd`
is not `null`.


> Upgrade bountycastle to 1.55+
> -----------------------------
>
>                 Key: CLOUDSTACK-9632
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9632
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>             Fix For: Future, 4.10.0.0
>
>
> Upgrade bountycastle library to latest versions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message