cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9632) Upgrade bountycastle to 1.55+
Date Wed, 30 Nov 2016 22:38:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710054#comment-15710054
] 

ASF GitHub Bot commented on CLOUDSTACK-9632:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1799#discussion_r90315448
  
    --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java ---
    @@ -150,26 +155,26 @@ public SslCertResponse uploadSslCert(UploadSslCertCmd certCmd) {
         @DB
         @Override
         @ActionEvent(eventType = EventTypes.EVENT_LB_CERT_DELETE, eventDescription = "Deleting
a certificate to cloudstack", async = false)
    -    public void deleteSslCert(DeleteSslCertCmd deleteSslCertCmd) {
    +    public void deleteSslCert(final DeleteSslCertCmd deleteSslCertCmd) {
    --- End diff --
    
    Please consider adding a `Preconditions.checkArgument` to check that `deleteSslCertCmd`
is not null.


> Upgrade bountycastle to 1.55+
> -----------------------------
>
>                 Key: CLOUDSTACK-9632
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9632
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>             Fix For: Future, 4.10.0.0
>
>
> Upgrade bountycastle library to latest versions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message