cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9572) Snapshot on primary storage not cleaned up after Storage migration
Date Mon, 14 Nov 2016 23:03:58 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665316#comment-15665316
] 

ASF GitHub Bot commented on CLOUDSTACK-9572:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1740#discussion_r87913074
  
    --- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ---
    @@ -1111,6 +1111,20 @@ public boolean canOperateOnVolume(Volume volume) {
         }
     
         @Override
    +    public void cleanupSnapshotsByVolume(Long volumeId) {
    +        List<SnapshotVO> volSnapShots = _snapshotDao.listByVolumeId(volumeId);
    +        for(SnapshotVO snapshot: volSnapShots) {
    +            SnapshotInfo info = snapshotFactory.getSnapshot(snapshot.getId(), DataStoreRole.Primary);
    +            try {
    +                snapshotSrv.deleteSnapshot(info);
    +            } catch(CloudRuntimeException e) {
    +                String msg = "Cleanup of Snapshot with uuid " + snapshot.getUuid() +
" in primary storage is failed. Ignoring";
    --- End diff --
    
    This local variable is only used once.  Please consider collapsing into lint 1122.  Also,
please add the message from the exception to the message to provide greater detail for debugging
efforts.


> Snapshot on primary storage not cleaned up after Storage migration
> ------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9572
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9572
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Storage Controller
>    Affects Versions: 4.8.0
>         Environment: Xen Server
>            Reporter: subhash yedugundla
>             Fix For: 4.8.1
>
>
> Issue Description
> ===============
> 1. Create an instance on the local storage on any host
> 2. Create a scheduled snapshot of the volume:
> 3. Wait until ACS created the snapshot. ACS is creating a snapshot on local storage and
is transferring this snapshot to secondary storage. But the latest snapshot on local storage
will stay there. This is as expected.
> 4. Migrate the instance to another XenServer host with ACS UI and Storage Live Migration
> 5. The Snapshot on the old host on local storage will not be cleaned up and is staying
on local storage. So local storage will fill up with unneeded snapshots.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message