Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Tue, 25 Oct 2016 09:27:58 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.13014700.1477311544000.77218.1477387678390@Atlassian.JIRA>
In-Reply-To: <JIRA.13014700.1477311544000@Atlassian.JIRA>
References: <JIRA.13014700.1477311544000@Atlassian.JIRA> <JIRA.13014700.1477311544431@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9560) Root volume of deleted VM left
 unremoved
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 25 Oct 2016 09:28:00 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15604768#comment-15604768 ] 

ASF GitHub Bot commented on CLOUDSTACK-9560:
--------------------------------------------

Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1726#discussion_r84862649
  
    --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
    @@ -2199,15 +2199,20 @@ public void cleanupDownloadUrls(){
                     if(downloadUrlCurrentAgeInSecs < _downloadUrlExpirationInterval){  // URL hasnt expired yet
                         continue;
                     }
    -
    -                s_logger.debug("Removing download url " + volumeOnImageStore.getExtractUrl() + " for volume id " + volumeOnImageStore.getVolumeId());
    +                long volumeId = volumeOnImageStore.getVolumeId();
    +                s_logger.debug("Removing download url " + volumeOnImageStore.getExtractUrl() + " for volume id " + volumeId);
     
                     // Remove it from image store
                     ImageStoreEntity secStore = (ImageStoreEntity) _dataStoreMgr.getDataStore(volumeOnImageStore.getDataStoreId(), DataStoreRole.Image);
                     secStore.deleteExtractUrl(volumeOnImageStore.getInstallPath(), volumeOnImageStore.getExtractUrl(), Upload.Type.VOLUME);
     
                     // Now expunge it from DB since this entry was created only for download purpose
                     _volumeStoreDao.expunge(volumeOnImageStore.getId());
    +                Volume volume = _volumeDao.findById(volumeId);
    +                if (volume.getState() == Volume.State.Expunged)
    --- End diff --
    
    @yvsubhash It is not about the DB relationship, is it possible that some other thread went ahead and deleted the volume entry after the store_ref entries are queried?


> Root volume of deleted VM left unremoved
> ----------------------------------------
>
>                 Key: CLOUDSTACK-9560
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9560
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Volumes
>    Affects Versions: 4.8.0
>         Environment: XenServer
>            Reporter: subhash yedugundla
>             Fix For: 4.8.1
>
>
> In the following scenario root volume gets unremoved
> Steps to reproduce the issue
> 1. Create a VM.
> 2. Stop this VM.
> 3. On the page of the volume of the VM, click 'Download Volume' icon.
> 4. Wait for the popup screen to display and cancel out with/without clicking the download link.
> 5. Destroy the VM
> Even after the corresponding VM is deleted,expunged, the root-volume is left in 'Expunging' state unremoved.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)