cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9539) Support changing Service offering for instance with VM Snapshots
Date Mon, 24 Oct 2016 18:54:58 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15602878#comment-15602878
] 

ASF GitHub Bot commented on CLOUDSTACK-9539:
--------------------------------------------

Github user ustcweizhou commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1727#discussion_r84757955
  
    --- Diff: setup/db/db/schema-490to4910.sql ---
    @@ -50,3 +50,8 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type,
hypervis
     -- Ubuntu 16.04 XenServer guest os mapping
     INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version,
guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '6.5.0',
'Ubuntu Trusty Tahr 14.04', 255, utc_timestamp(), 0);
     INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervisor_version,
guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(),'Xenserver', '6.5.0',
'Ubuntu Trusty Tahr 14.04', 256, utc_timestamp(), 0);
    +
    +-- Add service_offering_id column to vm_snapshots table
    +ALTER TABLE `cloud`.`vm_snapshots` ADD COLUMN `service_offering_id` BIGINT(20) UNSIGNED
NOT NULL COMMENT '' AFTER `domain_id`;
    +UPDATE vm_snapshots s JOIN vm_instance v ON v.id = s.vm_id SET s.service_offering_id
= v.service_offering_id;
    --- End diff --
    
    it is better to use 
    UPDATE `cloud`.`vm_snapshots` s JOIN `cloud`.`vm_instance` v ON v.id = s.vm_id SET s.service_offering_id
= v.service_offering_id;


> Support changing Service offering for instance with VM Snapshots
> ----------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9539
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9539
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Nicolas Vazquez
>            Assignee: Nicolas Vazquez
>
> h3. Actual behaviour
> CloudStack doesn't support changing service offering for vm instances which have vm snapshots,
they should be removed before changing service offering.
> h3. Goal
> Extend actual behaviour by supporting changing service offering for vms which have vm
snapshots. In that case, previously taken snapshots (if reverted) should use previous service
offering, future snapshots should use the newest.
> h3. Proposed solution:
> 1. Adding {{service_offering_id}} column on {{vm_snapshots}} table: This way snapshot
can be reverted to original state even though service offering can be changed for vm instance.
> NOTE: Existing vm snapshots are populated on update script by {{UPDATE vm_snapshots s
JOIN vm_instance v ON v.id = s.vm_id SET s.service_offering_id = v.service_offering_id;}}
> 2. New vm snapshots will use instance vm service offering id as {{service_offering_id}}
> 3. Revert to vm snapshots should use vm snapshot's {{service_offering_id}} value.
> h3. Example use case:
> - Deploy vm using service offering A
> - Take vm snapshot -> snap1 (service offering A)
> - Stop vm
> - Change vm service offering to B
> - Revert to VM snapshot snap 1
> - Start vm
> It is expected that vm has service offering A after last step



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message