cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9438) Fix for CLOUDSTACK-9252 - Make NFS version changeable in UI
Date Wed, 26 Oct 2016 17:02:58 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609019#comment-15609019
] 

ASF GitHub Bot commented on CLOUDSTACK-9438:
--------------------------------------------

Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1615
  
    <b>Trillian test result (tid-193)</b>
    Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
    Total time taken: 25817 seconds
    Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1615-t193-kvm-centos7.zip
    Test completed. 39 look ok, 9 have error(s)
    
    
    Test | Result | Time (s) | Test File
    --- | --- | --- | ---
    test_02_VPC_default_routes | `Failure` | 130.97 | test_vpc_router_nics.py
    test_02_redundant_VPC_default_routes | `Failure` | 248.71 | test_vpc_redundant.py
    test_router_dhcphosts | `Failure` | 85.95 | test_router_dhcphosts.py
    test_04_rvpc_privategw_static_routes | `Failure` | 137.70 | test_privategw_acl.py
    test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 72.29 | test_privategw_acl.py
    test_02_vpc_privategw_static_routes | `Failure` | 87.48 | test_privategw_acl.py
    test_01_vpc_privategw_acl | `Failure` | 37.02 | test_privategw_acl.py
    test_isolate_network_password_server | `Failure` | 55.87 | test_password_server.py
    test_oobm_zchange_password | `Failure` | 20.44 | test_outofbandmanagement.py
    test_01_vpc_remote_access_vpn | `Error` | 0.08 | test_vpc_vpn.py
    ContextSuite context=TestRVPCSite2SiteVpn>:teardown | `Error` | 240.88 | test_vpc_vpn.py
    ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 131.30 | test_router_dhcphosts.py
    test_extendPhysicalNetworkVlan | `Error` | 0.04 | test_non_contigiousvlan.py
    test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 741.16 | test_network.py
    test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 740.25 | test_network.py
    test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 730.93 | test_network.py
    ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.00 | test_guest_vlan_range.py
    test_01_vpc_site2site_vpn | Success | 144.87 | test_vpc_vpn.py
    test_01_redundant_vpc_site2site_vpn | Success | 235.78 | test_vpc_vpn.py
    test_01_VPC_nics_after_destroy | Success | 567.08 | test_vpc_router_nics.py
    test_05_rvpc_multi_tiers | Success | 415.30 | test_vpc_redundant.py
    test_04_rvpc_network_garbage_collector_nics | Success | 1516.19 | test_vpc_redundant.py
    test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 394.00
| test_vpc_redundant.py
    test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 946.00 | test_vpc_redundant.py
    test_09_delete_detached_volume | Success | 15.46 | test_volumes.py
    test_08_resize_volume | Success | 15.40 | test_volumes.py
    test_07_resize_fail | Success | 20.43 | test_volumes.py
    test_06_download_detached_volume | Success | 15.26 | test_volumes.py
    test_05_detach_volume | Success | 100.22 | test_volumes.py
    test_04_delete_attached_volume | Success | 10.21 | test_volumes.py
    test_03_download_attached_volume | Success | 15.25 | test_volumes.py
    test_02_attach_volume | Success | 43.62 | test_volumes.py
    test_01_create_volume | Success | 621.28 | test_volumes.py
    test_deploy_vm_multiple | Success | 254.26 | test_vm_life_cycle.py
    test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
    test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
    test_10_attachAndDetach_iso | Success | 71.79 | test_vm_life_cycle.py
    test_09_expunge_vm | Success | 125.16 | test_vm_life_cycle.py
    test_08_migrate_vm | Success | 35.89 | test_vm_life_cycle.py
    test_07_restore_vm | Success | 0.14 | test_vm_life_cycle.py
    test_06_destroy_vm | Success | 125.80 | test_vm_life_cycle.py
    test_03_reboot_vm | Success | 125.83 | test_vm_life_cycle.py
    test_02_start_vm | Success | 5.13 | test_vm_life_cycle.py
    test_01_stop_vm | Success | 35.27 | test_vm_life_cycle.py
    test_CreateTemplateWithDuplicateName | Success | 90.70 | test_templates.py
    test_08_list_system_templates | Success | 0.03 | test_templates.py
    test_07_list_public_templates | Success | 0.06 | test_templates.py
    test_05_template_permissions | Success | 0.06 | test_templates.py
    test_04_extract_template | Success | 5.19 | test_templates.py
    test_03_delete_template | Success | 5.11 | test_templates.py
    test_02_edit_template | Success | 90.17 | test_templates.py
    test_01_create_template | Success | 55.51 | test_templates.py
    test_10_destroy_cpvm | Success | 131.32 | test_ssvm.py
    test_09_destroy_ssvm | Success | 163.19 | test_ssvm.py
    test_08_reboot_cpvm | Success | 131.31 | test_ssvm.py
    test_07_reboot_ssvm | Success | 103.11 | test_ssvm.py
    test_06_stop_cpvm | Success | 131.50 | test_ssvm.py
    test_05_stop_ssvm | Success | 133.21 | test_ssvm.py
    test_04_cpvm_internals | Success | 0.97 | test_ssvm.py
    test_03_ssvm_internals | Success | 16.17 | test_ssvm.py
    test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
    test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
    test_01_snapshot_root_disk | Success | 66.50 | test_snapshots.py
    test_04_change_offering_small | Success | 210.51 | test_service_offerings.py
    test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
    test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
    test_01_create_service_offering | Success | 0.14 | test_service_offerings.py
    test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
    test_01_sys_vm_start | Success | 0.21 | test_secondary_storage.py
    test_09_reboot_router | Success | 35.48 | test_routers.py
    test_08_start_router | Success | 30.26 | test_routers.py
    test_07_stop_router | Success | 10.14 | test_routers.py
    test_06_router_advanced | Success | 0.05 | test_routers.py
    test_05_router_basic | Success | 0.04 | test_routers.py
    test_04_restart_network_wo_cleanup | Success | 5.56 | test_routers.py
    test_03_restart_network_cleanup | Success | 50.79 | test_routers.py
    test_02_router_internal_adv | Success | 0.84 | test_routers.py
    test_01_router_internal_basic | Success | 0.45 | test_routers.py
    test_router_dns_guestipquery | Success | 76.68 | test_router_dns.py
    test_router_dns_externalipquery | Success | 0.05 | test_router_dns.py
    test_01_updatevolumedetail | Success | 0.07 | test_resource_detail.py
    test_01_reset_vm_on_reboot | Success | 171.13 | test_reset_vm_on_reboot.py
    test_createRegion | Success | 0.04 | test_regions.py
    test_create_pvlan_network | Success | 5.21 | test_pvlan.py
    test_dedicatePublicIpRange | Success | 0.39 | test_public_ip_range.py
    test_01_primary_storage_nfs | Success | 35.73 | test_primary_storage.py
    test_createPortablePublicIPRange | Success | 15.19 | test_portable_publicip.py
    test_createPortablePublicIPAcquire | Success | 15.41 | test_portable_publicip.py
    test_UpdateStorageOverProvisioningFactor | Success | 0.12 | test_over_provisioning.py
    test_oobm_multiple_mgmt_server_ownership | Success | 16.49 | test_outofbandmanagement.py
    test_oobm_issue_power_status | Success | 10.53 | test_outofbandmanagement.py
    test_oobm_issue_power_soft | Success | 15.52 | test_outofbandmanagement.py
    test_oobm_issue_power_reset | Success | 15.52 | test_outofbandmanagement.py
    test_oobm_issue_power_on | Success | 15.52 | test_outofbandmanagement.py
    test_oobm_issue_power_off | Success | 15.52 | test_outofbandmanagement.py
    test_oobm_issue_power_cycle | Success | 15.52 | test_outofbandmanagement.py
    test_oobm_enabledisable_across_clusterzones | Success | 57.25 | test_outofbandmanagement.py
    test_oobm_enable_feature_valid | Success | 5.16 | test_outofbandmanagement.py
    test_oobm_enable_feature_invalid | Success | 0.10 | test_outofbandmanagement.py
    test_oobm_disable_feature_valid | Success | 5.18 | test_outofbandmanagement.py
    test_oobm_disable_feature_invalid | Success | 0.12 | test_outofbandmanagement.py
    test_oobm_configure_invalid_driver | Success | 0.09 | test_outofbandmanagement.py
    test_oobm_configure_default_driver | Success | 0.09 | test_outofbandmanagement.py
    test_oobm_background_powerstate_sync | Success | 24.67 | test_outofbandmanagement.py
    test_01_nic | Success | 681.32 | test_nic.py
    test_releaseIP | Success | 148.03 | test_network.py
    test_reboot_router | Success | 409.31 | test_network.py
    test_public_ip_user_account | Success | 10.23 | test_network.py
    test_public_ip_admin_account | Success | 40.26 | test_network.py
    test_delete_account | Success | 298.67 | test_network.py
    test_02_port_fwd_on_non_src_nat | Success | 55.64 | test_network.py
    test_01_port_fwd_on_src_nat | Success | 111.71 | test_network.py
    test_nic_secondaryip_add_remove | Success | 193.41 | test_multipleips_per_nic.py
    login_test_saml_user | Success | 24.53 | test_login.py
    test_assign_and_removal_lb | Success | 132.65 | test_loadbalance.py
    test_02_create_lb_rule_non_nat | Success | 186.79 | test_loadbalance.py
    test_01_create_lb_rule_src_nat | Success | 207.21 | test_loadbalance.py
    test_03_list_snapshots | Success | 0.05 | test_list_ids_parameter.py
    test_02_list_templates | Success | 0.04 | test_list_ids_parameter.py
    test_01_list_volumes | Success | 0.03 | test_list_ids_parameter.py
    test_07_list_default_iso | Success | 0.14 | test_iso.py
    test_05_iso_permissions | Success | 0.06 | test_iso.py
    test_04_extract_Iso | Success | 5.17 | test_iso.py
    test_03_delete_iso | Success | 95.16 | test_iso.py
    test_02_edit_iso | Success | 0.08 | test_iso.py
    test_01_create_iso | Success | 66.81 | test_iso.py
    test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 223.50 | test_internal_lb.py
    test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 167.76 | test_internal_lb.py
    test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 494.64 | test_internal_lb.py
    test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 413.47 | test_internal_lb.py
    test_UpdateConfigParamWithScope | Success | 0.15 | test_global_settings.py
    test_rolepermission_lifecycle_update | Success | 7.14 | test_dynamicroles.py
    test_rolepermission_lifecycle_list | Success | 6.84 | test_dynamicroles.py
    test_rolepermission_lifecycle_delete | Success | 6.79 | test_dynamicroles.py
    test_rolepermission_lifecycle_create | Success | 6.78 | test_dynamicroles.py
    test_rolepermission_lifecycle_concurrent_updates | Success | 6.85 | test_dynamicroles.py
    test_role_lifecycle_update_role_inuse | Success | 6.85 | test_dynamicroles.py
    test_role_lifecycle_update | Success | 11.90 | test_dynamicroles.py
    test_role_lifecycle_list | Success | 6.81 | test_dynamicroles.py
    test_role_lifecycle_delete | Success | 12.51 | test_dynamicroles.py
    test_role_lifecycle_create | Success | 6.95 | test_dynamicroles.py
    test_role_inuse_deletion | Success | 7.07 | test_dynamicroles.py
    test_role_account_acls_multiple_mgmt_servers | Success | 8.96 | test_dynamicroles.py
    test_role_account_acls | Success | 9.10 | test_dynamicroles.py
    test_default_role_deletion | Success | 6.85 | test_dynamicroles.py
    test_04_create_fat_type_disk_offering | Success | 0.06 | test_disk_offerings.py
    test_03_delete_disk_offering | Success | 0.04 | test_disk_offerings.py
    test_02_edit_disk_offering | Success | 0.05 | test_disk_offerings.py
    test_02_create_sparse_type_disk_offering | Success | 0.06 | test_disk_offerings.py
    test_01_create_disk_offering | Success | 0.10 | test_disk_offerings.py
    test_deployvm_userdispersing | Success | 20.53 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userconcentrated | Success | 20.57 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_firstfit | Success | 86.00 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userdata_post | Success | 5.34 | test_deploy_vm_with_userdata.py
    test_deployvm_userdata | Success | 45.63 | test_deploy_vm_with_userdata.py
    test_02_deploy_vm_root_resize | Success | 6.84 | test_deploy_vm_root_resize.py
    test_01_deploy_vm_root_resize | Success | 6.96 | test_deploy_vm_root_resize.py
    test_00_deploy_vm_root_resize | Success | 228.35 | test_deploy_vm_root_resize.py
    test_deploy_vm_from_iso | Success | 243.13 | test_deploy_vm_iso.py
    test_DeployVmAntiAffinityGroup | Success | 55.88 | test_affinity_groups.py
    test_03_delete_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
    test_02_revert_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
    test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
    test_01_create_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
    test_06_copy_template | Skipped | 0.00 | test_templates.py
    test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
    test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
    test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
    test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
    test_06_copy_iso | Skipped | 0.00 | test_iso.py
    test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
    test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py



> Fix for CLOUDSTACK-9252 - Make NFS version changeable in UI
> -----------------------------------------------------------
>
>                 Key: CLOUDSTACK-9438
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9438
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Nicolas Vazquez
>            Assignee: Nicolas Vazquez
>
> h3. Introduction
> From [9252|https://issues.apache.org/jira/browse/CLOUDSTACK-9252] it was possible to
configure NFS version for secondary storage mount. 
> However, changing NFS version requires inserting an new detail on {{image_store_details}}
table, with {{name = 'nfs.version'}} and {{value = X}} where X is desired NFS version, and
then restarting management server for changes to take effect.
> Our improvement aims to make NFS version changeable from UI, instead of previously described
workflow.
> h3. Proposed solution
> Basically, NFS version is defined as an image store ConfigKey, this implied:
> * Adding a new Config scope: *ImageStore*
> * Make {{ImageStoreDetailsDao}} class to extend {{ResourceDetailsDaoBase}} and {{ImageStoreDetailVO}}
implement {{ResourceDetail}}
> * Insert {{'display'}} column on {{image_store_details}} table
> * Extending {{ListCfgsCmd}} and {{UpdateCfgCmd}} to support *ImageStore* scope, which
implied:
> ** Injecting {{ImageStoreDetailsDao}} and {{ImageStoreDao}} on {{ConfigurationManagerImpl}}
class, on {{cloud-server}} module.
> h4. Important
> It is important to mention that {{ImageStoreDaoImpl}} and {{ImageStoreDetailsDaoImpl}}
classes were moved from {{cloud-engine-storage}} to {{cloud-engine-schema}} module in order
to Spring find those beans to inject on {{ConfigurationManagerImpl}} in {{cloud-server}} module.
> We had this maven dependencies between modules:
> * {{cloud-server --> cloud-engine-schema}}
> * {{cloud-engine-storage --> cloud-secondary-storage --> cloud-server}}
> As {{ImageStoreDaoImpl}} and {{ImageStoreDetailsDaoImpl}} were defined in {{cloud-engine-storage}},
and they needed in {{cloud-server}} module, to be injected on {{ConfigurationManagerImpl}},
if we added dependency from {{cloud-server}} to {{cloud-engine-storage}} we would introduce
a dependency cycle. To avoid this cycle, we moved those classes to {{cloud-engine-schema}}
module



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message