Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Thu, 22 Sep 2016 15:23:21 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.13006101.1474344929000.639063.1474557801640@Atlassian.JIRA>
In-Reply-To: <JIRA.13006101.1474344929000@Atlassian.JIRA>
References: <JIRA.13006101.1474344929000@Atlassian.JIRA> <JIRA.13006101.1474344929699@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9503) The router script times out
 resulting in failure of deployment
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 22 Sep 2016 15:24:16 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9503?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D15513590#comment-15513590 ]=20

ASF GitHub Bot commented on CLOUDSTACK-9503:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1678#discussion_r80065874
 =20
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenser=
ver/resource/CitrixResourceBase.java ---
    @@ -1660,18 +1661,18 @@ public StopAnswer execute(final StopCommand cmd=
) {
         @Override
         public ExecutionResult executeInVR(final String routerIP, final St=
ring script, final String args) {
             // Timeout is 120 seconds by default
    -        return executeInVR(routerIP, script, args, 120);
    +        return executeInVR(routerIP, script, args, Duration.standardSe=
conds(120L));
         }
    =20
         @Override
    -    public ExecutionResult executeInVR(final String routerIP, final St=
ring script, final String args, final int timeout) {
    +    public ExecutionResult executeInVR(final String routerIP, final St=
ring script, final String args, final Duration timeout) {
             Pair<Boolean, String> result;
             String cmdline =3D "/opt/cloud/bin/router_proxy.sh " + script =
+ " " + routerIP + " " + args;
             // semicolon need to be escape for bash
             cmdline =3D cmdline.replaceAll(";", "\\\\;");
             try {
                 s_logger.debug("Executing command in VR: " + cmdline);
    -            result =3D SshHelper.sshExecute(_host.getIp(), 22, _userna=
me, null, _password.peek(), cmdline, 60000, 60000, timeout * 1000);
    +            result =3D SshHelper.sshExecute(_host.getIp(), 22, _userna=
me, null, _password.peek(), cmdline, 60000, 60000, (int)timeout.getMillis()=
);
    --- End diff --
   =20
    Please consider adding an overridden version of the `SshHelper.sshExecu=
te(String, int, String, String, ??, String, int, int, int)` method that acc=
epts `Duration` to encapsulate this type conversion.


> The router script times out resulting in failure of deployment
> --------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9503
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-950=
3
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the defa=
ult.)=20
>          Components: Virtual Router
>    Affects Versions: 4.9.0
>         Environment: KVM, Xen
>            Reporter: Abhinandan Prateek
>            Assignee: Abhinandan Prateek
>             Fix For: 4.9.1.0
>
>
> When starting the virtual router in a shared network in advance zone the =
scripts on router time out. This happen as there are several sub-commands t=
hat are consolidated in a single command. The default timeout of 2 minutes =
is short.
> 2016-09-09 00:06:25,016 ERROR [c.c.n.r.VirtualNetworkApplianceManagerImpl=
] (Work-Job-Executor-110:ctx-e8089ec7 job-5135/job-5137 ctx-c3a8da18) (logi=
d:8aedea66) process hasn't exited
> 2016-09-09 00:06:25,016 WARN [c.c.n.r.VirtualNetworkApplianceManagerImpl]=
 (Work-Job-Executor-110:ctx-e8089ec7 job-5135/job-5137 ctx-c3a8da18) (logid=
:8aedea66) Command: com.cloud.agent.api.Command failed while starting virtu=
al router
> 2016-09-09 00:06:25,016 INFO [c.c.v.VirtualMachineManagerImpl] (Work-Job-=
Executor-110:ctx-e8089ec7 job-5135/job-5137 ctx-c3a8da18) (logid:8aedea66) =
The guru did not like the answers so stopping VM[DomainRouter|r-3445-VM]
> =E2=80=94


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)