Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Wed, 7 Sep 2016 03:48:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12975102.1464858883000.504014.1473220100534@Atlassian.JIRA>
In-Reply-To: <JIRA.12975102.1464858883000@Atlassian.JIRA>
References: <JIRA.12975102.1464858883000@Atlassian.JIRA> <JIRA.12975102.1464858883961@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9401) Nuage VSP Plugin : Support for
 InternalDns including Marvin test coverage
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 07 Sep 2016 03:48:22 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469432#comment-15469432 ] 

ASF GitHub Bot commented on CLOUDSTACK-9401:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1578#discussion_r77756445
  
    --- Diff: test/integration/plugins/nuagevsp/nuageTestCase.py ---
    @@ -490,57 +581,75 @@ def execute_cmd(self, ssh_client, cmd):
                 self.debug("SSH client executed command result is None")
             return ret_data
     
    -    # wget_from_server - Fetches index.html file from a web server listening on the given public IP address and port
    -    def wget_from_server(self, public_ip, port):
    +    # wget_from_server - Fetches file with the given file name from a web
    +    # server listening on the given public IP address and port
    +    def wget_from_server(self, public_ip, port, file_name="index.html"):
             import urllib
    -        self.debug("wget index.html file from a http web server listening on public IP address - %s and port - %s" %
    -                   (public_ip.ipaddress.ipaddress, port))
    -        filename, headers = urllib.urlretrieve("http://%s:%s/index.html" % (public_ip.ipaddress.ipaddress, port),
    -                                               filename="index.html"
    -                                               )
    +        self.debug("wget file - %s from a http web server listening on "
    +                   "public IP address - %s and port - %s" %
    +                   (file_name, public_ip.ipaddress.ipaddress, port))
    +        filename, headers = urllib.urlretrieve(
    +            "http://%s:%s/%s" %
    +            (public_ip.ipaddress.ipaddress, port, file_name),
    +            filename=file_name
    +        )
    --- End diff --
    
    Please add assertions that ``filename`` and ``header`` are as expected (e.g. not ``None``).


> Nuage VSP Plugin : Support for InternalDns including Marvin test coverage
> -------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9401
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9401
>             Project: CloudStack
>          Issue Type: Task
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Automation, Network Controller
>            Reporter: Rahul Singal
>            Assignee: Nick Livens
>
> Supporting Internal Dns by using Dns service provider as Virtual Router but Dhcp provider will be NuageVsp. The idea is here is to keep using Internal Dns service of cloudstack when network provider is some other vendor.
> A sample network offering will be like below one:-
> Service                       Provider
> DHCP                         NuageVsp
> DNS                            VirtualRouter/VpcVirtualRouter
> UserData                    VirtualRouter/VpcVirtualRouter
> Virtual Networking       NuageVsp
> SourceNat                   NuageVsp
> StaticNat                     NuageVsp
> NetworkAcl/Firewall    NuageVsp
> Testrun:-
> Verify InternalDns on Isolated Network ... === TestName: test_01_Isolated_Network_with_zone | Status : SUCCESS ===
> ok
> Verify InternalDns on Isolated Network with ping by hostname ... === TestName: test_02_Isolated_Network | Status : SUCCESS ===
> ok
> Verify update NetworkDomain for InternalDns on Isolated Network ... === TestName: test_03_Update_Network_with_Domain | Status : SUCCESS ===
> ok
> Verify update NetworkDomain for InternalDns on Isolated Network with ping VM ... === TestName: test_04_Update_Network_with_Domain | Status : SUCCESS ===
> ok
> Verify InternalDns on VPC Network ... === TestName: test_05_VPC_Network_With_InternalDns | Status : SUCCESS ===
> ok
> Verify InternalDns on VPC Network by ping with hostname ... === TestName: test_06_VPC_Network_With_InternalDns | Status : SUCCESS ===
> ok
> ----------------------------------------------------------------------
> Ran 6 tests in 5736.562s
> OK
> cloudstack$ pep8 --max-line-length=150 test_internal_dns.py
> cloudstack$  pyflakes test_internal_dns.py
> cloudstack$


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)