Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E666C200B95 for ; Tue, 27 Sep 2016 19:48:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E2E0E160AE5; Tue, 27 Sep 2016 17:48:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3F094160AE7 for ; Tue, 27 Sep 2016 19:48:22 +0200 (CEST) Received: (qmail 48572 invoked by uid 500); 27 Sep 2016 17:48:21 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 48335 invoked by uid 500); 27 Sep 2016 17:48:20 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 48296 invoked by uid 99); 27 Sep 2016 17:48:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Sep 2016 17:48:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id B9F4C2C2A69 for ; Tue, 27 Sep 2016 17:48:20 +0000 (UTC) Date: Tue, 27 Sep 2016 17:48:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9379) Support nested virtualization at VM level on VMware Hypervisor MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 27 Sep 2016 17:48:23 -0000 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526903#comment-15526903 ] ASF GitHub Bot commented on CLOUDSTACK-9379: -------------------------------------------- Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1542 @jburwell Creating Marvin test for this PR will be a huge undertaking. It would require building and configuring a hypervisor in a deployed VM and then creating VM in VM. Considering storage, environmental and network implication the test will be complicated and error prone. An alternative approach would require integrating vSphere SDK with Marvin python libraries and query vSphere for the actual nested virtualization settings from a deployed VM. The effort doesn't seem to be warranted for such a minor change. As long as standard integration suite is passing this shouldn't affect any existing functionality. What do you think? > Support nested virtualization at VM level on VMware Hypervisor > -------------------------------------------------------------- > > Key: CLOUDSTACK-9379 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9379 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the default.) > Components: VMware > Affects Versions: 4.9.0 > Reporter: Nicolas Vazquez > Assignee: Nicolas Vazquez > Fix For: 4.10.0.0 > > > h2. Introduction > It is desired to support nested virtualization at VM level for VMware hypervisor. Current behaviour supports enabling/desabling global nested virtualization by modifying global config {{'vmware.nested.virtualization'}}. It is wished to improve this feature, having control at VM level instead of a global control only. > h2. Proposal > A new global configuration is added, to enable/disable VM nested virtualization control: {{'vmware.nested.virtualization.perVM'}}. Default value=false > h2. Behaviour > After a vm deployment or start command, vm params include {{nestedVirtualizationFlag}} key and its value is: > * true -> nested virtualization enabled > * false -> nested virtualization disabled > We will determinate nested virtualization enabled/disabled by examining: > * (1) global configuration {{'vmware.nested.virtualization'}} value > * (2) global configuration {{'vmware.nested.virtualization.perVM'}} value > * (3) {{'nestedVirtualizationFlag'}} value in {{user_vm_details}} if present, null if not. > Using this 3 values, there are different use cases: > # (1) = TRUE, (2) = TRUE, (3) is null -> ENABLED > # (1) = TRUE, (2) = TRUE, (3) = TRUE -> ENABLED > # (1) = TRUE, (2) = TRUE, (3) = FALSE -> DISABLED > # (1) = TRUE, (2) = FALSE -> ENABLED > # (1) = FALSE, (2) = TRUE, (3) is null -> DISABLED > # (1) = FALSE, (2) = TRUE, (3) = TRUE -> ENABLED > # (1) = FALSE, (2) = TRUE, (3) = FALSE -> DISABLED > # (1) = FALSE, (2) = FALSE -> DISABLED -- This message was sent by Atlassian JIRA (v6.3.4#6332)