From issues-return-73254-apmail-cloudstack-issues-archive=cloudstack.apache.org@cloudstack.apache.org Sat Sep 10 21:24:20 2016 Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D694E19382 for ; Sat, 10 Sep 2016 21:24:20 +0000 (UTC) Received: (qmail 18530 invoked by uid 500); 10 Sep 2016 21:24:20 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 18493 invoked by uid 500); 10 Sep 2016 21:24:20 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 18481 invoked by uid 500); 10 Sep 2016 21:24:20 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 18477 invoked by uid 99); 10 Sep 2016 21:24:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Sep 2016 21:24:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 82B662C1B79 for ; Sat, 10 Sep 2016 21:24:20 +0000 (UTC) Date: Sat, 10 Sep 2016 21:24:20 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9470) [BLOCKER] Bug in SshHelper affecting interaction with vRouter in VmwareResource and HypervDirectConnectResource MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15480484#comment-15480484 ] ASF subversion and git services commented on CLOUDSTACK-9470: ------------------------------------------------------------- Commit 1190d76a65e93eefec7c19255e07cea18cf4db1f in cloudstack's branch refs/heads/master from [~nicolas.vazquez] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1190d76 ] CLOUDSTACK-9470: Fix for SshHelper - test_network_acl was failing on Vmware due to a bug in sshExecute, in which value returned was null and there was still stdout to consume. This fix addresses this problem, consuming stdout peoperly to return expected value in sshExecute > [BLOCKER] Bug in SshHelper affecting interaction with vRouter in VmwareResource and HypervDirectConnectResource > --------------------------------------------------------------------------------------------------------------- > > Key: CLOUDSTACK-9470 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9470 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the default.) > Components: VMware > Affects Versions: 4.7.0, 4.8.0, 4.9.0 > Reporter: Nicolas Vazquez > Assignee: Nicolas Vazquez > Fix For: 4.10.0.0, 4.9.1.0 > > > h2. Problem > In a Vmware environment, running {{test_network_acl}} we examined why it was failing, it was discovered an issue on {{VmwareResource}}: > {code:title=VmwareResource.java|borderStyle=solid} > private int findRouterEthDeviceIndex(String domrName, String routerIp, String mac) throws Exception { > VmwareManager mgr = getServiceContext().getStockObject(VmwareManager.CONTEXT_STOCK_NAME); > s_logger.info("findRouterEthDeviceIndex. mac: " + mac); > // TODO : this is a temporary very inefficient solution, will refactor it later > Pair result = SshHelper.sshExecute(routerIp, DefaultDomRSshPort, "root", mgr.getSystemVMKeyFile(), null, "ls /proc/sys/net/ipv4/conf"); > {code} > Command sent to router returned a pair which its first parameter was always true but second parameter sometimes it was null and sometimes the correct output for given command. > h2. Solution > Examining {{SshHelper}} we discovered that cases in which second parameter in result was null, didn't consume stdout properly -- This message was sent by Atlassian JIRA (v6.3.4#6332)