From issues-return-73779-apmail-cloudstack-issues-archive=cloudstack.apache.org@cloudstack.apache.org Wed Sep 28 08:59:21 2016 Return-Path: X-Original-To: apmail-cloudstack-issues-archive@www.apache.org Delivered-To: apmail-cloudstack-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4D2EC19ED0 for ; Wed, 28 Sep 2016 08:59:21 +0000 (UTC) Received: (qmail 19817 invoked by uid 500); 28 Sep 2016 08:59:21 -0000 Delivered-To: apmail-cloudstack-issues-archive@cloudstack.apache.org Received: (qmail 19710 invoked by uid 500); 28 Sep 2016 08:59:21 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 19517 invoked by uid 500); 28 Sep 2016 08:59:20 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 19485 invoked by uid 99); 28 Sep 2016 08:59:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Sep 2016 08:59:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A4B142C2A6B for ; Wed, 28 Sep 2016 08:59:20 +0000 (UTC) Date: Wed, 28 Sep 2016 08:59:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9071) stats.output.uri stops the server from starting if the uri is malformed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15528969#comment-15528969 ] ASF GitHub Bot commented on CLOUDSTACK-9071: -------------------------------------------- GitHub user wido reopened a pull request: https://github.com/apache/cloudstack/pull/1673 CLOUDSTACK-9071: Properly parse stats.output.uri in StatsCollector Both host and path could have been NULL which causes the StatsCollector no to start properly. By checking if the Strings are not Empty or Null we make sure the StatsCollector always runs and does not prevent the Management Server from starting. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wido/cloudstack CLOUDSTACK-9071 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1673.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1673 ---- commit f95022153506a03b3eed572f6b7cc978cad0f315 Author: Wido den Hollander Date: 2016-09-15T10:18:21Z CLOUDSTACK-9071: Properly parse stats.output.uri in StatsCollector Both host and path could have been NULL which causes the StatsCollector no to start properly. By checking if the Strings are not Empty or Null we make sure the StatsCollector always runs and does not prevent the Management Server from starting. Conflicts: server/src/com/cloud/server/StatsCollector.java ---- > stats.output.uri stops the server from starting if the uri is malformed > ----------------------------------------------------------------------- > > Key: CLOUDSTACK-9071 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9071 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Affects Versions: 4.6.0 > Reporter: Carles Figuerola > > After inputting a malformed uri (was missing the graphite://) and restarting the management service, the application stops at: > 2015-11-17 11:06:42,861 INFO [c.c.s.StatsCollector] (localhost-startStop-1:null) metrics.dev.company.net is not a valid protocol for external statistics. No statistics will be send. > No more logs are output and tomcat is up but serving a completely blank page. > When the uri has this form: (graphite://metrics.dev.company.net:2013), the end result is very similar to the previous one > (also, the last word should be "sent") -- This message was sent by Atlassian JIRA (v6.3.4#6332)