[ https://issues.apache.org/jira/browse/CLOUDSTACK-9071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15492951#comment-15492951 ] 

ASF GitHub Bot commented on CLOUDSTACK-9071:
--------------------------------------------

GitHub user wido opened a pull request:

    https://github.com/apache/cloudstack/pull/1673

    CLOUDSTACK-9071: Properly parse stats.output.uri in StatsCollector

    Both host and path could have been NULL which causes the StatsCollector
    no to start properly.
    
    By checking if the Strings are not Empty or Null we make sure the StatsCollector
    always runs and does not prevent the Management Server from starting.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wido/cloudstack CLOUDSTACK-9071

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1673.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1673
    
----
commit 11357259b1775e80afe6724b5dac2619587bb9d5
Author: Wido den Hollander <wido@widodh.nl>
Date:   2016-09-15T10:18:21Z

    CLOUDSTACK-9071: Properly parse stats.output.uri in StatsCollector
    
    Both host and path could have been NULL which causes the StatsCollector
    no to start properly.
    
    By checking if the Strings are not Empty or Null we make sure the StatsCollector
    always runs and does not prevent the Management Server from starting.

----


> stats.output.uri stops the server from starting if the uri is malformed
> -----------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9071
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9071
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.6.0
>            Reporter: Carles Figuerola
>
> After inputting a malformed uri (was missing the graphite://) and restarting the management service, the application stops at:
> 2015-11-17 11:06:42,861 INFO  [c.c.s.StatsCollector] (localhost-startStop-1:null) metrics.dev.company.net is not a valid protocol for external statistics. No statistics will be send.
> No more logs are output and tomcat is up but serving a completely blank page.
> When the uri has this form: (graphite://metrics.dev.company.net:2013), the end result is very similar to the previous one
> (also, the last word should be "sent")



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)