cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9401) Nuage VSP Plugin : Support for InternalDns including Marvin test coverage
Date Wed, 07 Sep 2016 03:47:20 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469430#comment-15469430
] 

ASF GitHub Bot commented on CLOUDSTACK-9401:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1578#discussion_r77756386
  
    --- Diff: test/integration/plugins/nuagevsp/nuageTestCase.py ---
    @@ -461,22 +547,27 @@ def create_NetworkAclRule(self, rule, traffic_type="Ingress", network=None,
acl_
                                          )
     
         # ssh_into_VM - Gets into the shell of the given VM using its public IP
    -    def ssh_into_VM(self, vm, public_ip, reconnect=True):
    -        self.debug("SSH into VM with ID - %s on public IP address - %s" % (vm.id, public_ip.ipaddress.ipaddress))
    -        tries = 0
    -        while tries < 3:
    +    def ssh_into_VM(self, vm, public_ip, reconnect=True, negative_test=False):
    +        self.debug("SSH into VM with ID - %s on public IP address - %s" %
    +                   (vm.id, public_ip.ipaddress.ipaddress))
    +        tries = 1 if negative_test else 3
    +        while True:
                 try:
    -                ssh_client = vm.get_ssh_client(ipaddress=public_ip.ipaddress.ipaddress,
reconnect=reconnect)
    +                ssh_client = vm.get_ssh_client(
    +                    ipaddress=public_ip.ipaddress.ipaddress,
    +                    reconnect=reconnect,
    +                    retries=3 if negative_test else 30
    +                )
    +                self.debug("Successful to SSH into VM with ID - %s on "
    +                           "public IP address - %s" %
    +                           (vm.id, public_ip.ipaddress.ipaddress))
    +                return ssh_client
                 except Exception as e:
                     self.debug("Failed to SSH into VM: %s" % e)
    -                self.debug("Waiting for the VM to be fully resolved for SSH connection...")
    -                time.sleep(120)
    +                tries -= 1
    +                if tries == 0:
    +                    raise e
    --- End diff --
    
    Please consider separating the retry logic into a utility function to make the code more
readable and promote reuse.


> Nuage VSP Plugin : Support for InternalDns including Marvin test coverage
> -------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9401
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9401
>             Project: CloudStack
>          Issue Type: Task
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Automation, Network Controller
>            Reporter: Rahul Singal
>            Assignee: Nick Livens
>
> Supporting Internal Dns by using Dns service provider as Virtual Router but Dhcp provider
will be NuageVsp. The idea is here is to keep using Internal Dns service of cloudstack when
network provider is some other vendor.
> A sample network offering will be like below one:-
> Service                       Provider
> DHCP                         NuageVsp
> DNS                            VirtualRouter/VpcVirtualRouter
> UserData                    VirtualRouter/VpcVirtualRouter
> Virtual Networking       NuageVsp
> SourceNat                   NuageVsp
> StaticNat                     NuageVsp
> NetworkAcl/Firewall    NuageVsp
> Testrun:-
> Verify InternalDns on Isolated Network ... === TestName: test_01_Isolated_Network_with_zone
| Status : SUCCESS ===
> ok
> Verify InternalDns on Isolated Network with ping by hostname ... === TestName: test_02_Isolated_Network
| Status : SUCCESS ===
> ok
> Verify update NetworkDomain for InternalDns on Isolated Network ... === TestName: test_03_Update_Network_with_Domain
| Status : SUCCESS ===
> ok
> Verify update NetworkDomain for InternalDns on Isolated Network with ping VM ... ===
TestName: test_04_Update_Network_with_Domain | Status : SUCCESS ===
> ok
> Verify InternalDns on VPC Network ... === TestName: test_05_VPC_Network_With_InternalDns
| Status : SUCCESS ===
> ok
> Verify InternalDns on VPC Network by ping with hostname ... === TestName: test_06_VPC_Network_With_InternalDns
| Status : SUCCESS ===
> ok
> ----------------------------------------------------------------------
> Ran 6 tests in 5736.562s
> OK
> cloudstack$ pep8 --max-line-length=150 test_internal_dns.py
> cloudstack$  pyflakes test_internal_dns.py
> cloudstack$



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message