cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9401) Nuage VSP Plugin : Support for InternalDns including Marvin test coverage
Date Wed, 07 Sep 2016 03:11:20 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469353#comment-15469353
] 

ASF GitHub Bot commented on CLOUDSTACK-9401:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1578#discussion_r77754300
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVspCommand.java
---
    @@ -0,0 +1,73 @@
    +//
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +//
    +
    +package com.cloud.agent.api.element;
    +
    +import net.nuage.vsp.acs.client.api.model.VspDhcpDomainOption;
    +import net.nuage.vsp.acs.client.api.model.VspNetwork;
    +
    +import com.cloud.agent.api.Command;
    +
    +public class ShutDownVspCommand extends Command {
    +
    +    private final VspNetwork _network;
    +    private final VspDhcpDomainOption _dhcpOptions;
    +
    +    public ShutDownVspCommand(VspNetwork network, VspDhcpDomainOption dhcpOptions) {
    +        super();
    +        this._network = network;
    +        this._dhcpOptions = dhcpOptions;
    +    }
    +
    +    public VspNetwork getNetwork() {
    +        return _network;
    +    }
    +
    +    public VspDhcpDomainOption getDhcpOptions() {
    +        return _dhcpOptions;
    +    }
    +
    +    @Override
    +    public boolean executeInSequence() {
    +        return false;
    +    }
    +
    +    @Override
    +    public boolean equals(Object o) {
    +        if (this == o) return true;
    +        if (!(o instanceof ShutDownVspCommand)) return false;
    +        if (!super.equals(o)) return false;
    --- End diff --
    
    Per our coding standards, please wrap these ``if`` blocks with curly braces.


> Nuage VSP Plugin : Support for InternalDns including Marvin test coverage
> -------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9401
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9401
>             Project: CloudStack
>          Issue Type: Task
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Automation, Network Controller
>            Reporter: Rahul Singal
>            Assignee: Nick Livens
>
> Supporting Internal Dns by using Dns service provider as Virtual Router but Dhcp provider
will be NuageVsp. The idea is here is to keep using Internal Dns service of cloudstack when
network provider is some other vendor.
> A sample network offering will be like below one:-
> Service                       Provider
> DHCP                         NuageVsp
> DNS                            VirtualRouter/VpcVirtualRouter
> UserData                    VirtualRouter/VpcVirtualRouter
> Virtual Networking       NuageVsp
> SourceNat                   NuageVsp
> StaticNat                     NuageVsp
> NetworkAcl/Firewall    NuageVsp
> Testrun:-
> Verify InternalDns on Isolated Network ... === TestName: test_01_Isolated_Network_with_zone
| Status : SUCCESS ===
> ok
> Verify InternalDns on Isolated Network with ping by hostname ... === TestName: test_02_Isolated_Network
| Status : SUCCESS ===
> ok
> Verify update NetworkDomain for InternalDns on Isolated Network ... === TestName: test_03_Update_Network_with_Domain
| Status : SUCCESS ===
> ok
> Verify update NetworkDomain for InternalDns on Isolated Network with ping VM ... ===
TestName: test_04_Update_Network_with_Domain | Status : SUCCESS ===
> ok
> Verify InternalDns on VPC Network ... === TestName: test_05_VPC_Network_With_InternalDns
| Status : SUCCESS ===
> ok
> Verify InternalDns on VPC Network by ping with hostname ... === TestName: test_06_VPC_Network_With_InternalDns
| Status : SUCCESS ===
> ok
> ----------------------------------------------------------------------
> Ran 6 tests in 5736.562s
> OK
> cloudstack$ pep8 --max-line-length=150 test_internal_dns.py
> cloudstack$  pyflakes test_internal_dns.py
> cloudstack$



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message