Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Thu, 25 Aug 2016 20:45:21 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12998436.1471596971000.413893.1472157921985@Atlassian.JIRA>
In-Reply-To: <JIRA.12998436.1471596971000@Atlassian.JIRA>
References: <JIRA.12998436.1471596971000@Atlassian.JIRA> <JIRA.12998436.1471596971584@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9462) Systemd packaging for Ubuntu
 16.04
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 25 Aug 2016 20:45:24 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437632#comment-15437632 ] 

ASF GitHub Bot commented on CLOUDSTACK-9462:
--------------------------------------------

Github user vincentbernat commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1647#discussion_r76320932
  
    --- Diff: packaging/systemd/cloudstack-agent.default ---
    @@ -0,0 +1,24 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +
    +JAVA_HOME=/usr/lib/jvm/jre
    +if [ ! -f "$JAVA_HOME"/bin/java ] ; then
    +    JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')
    +fi
    --- End diff --
    
    Are you sure this will work with systemd? On Ubuntu, the best it could do is to keep `JAVA_HOME=/usr/lib/jvm/jre` which is not valid on Ubuntu. Maybe, it would be easier to push that inside the ExecStart (and equivalent in init.d):
    
    ```
    if [ -n "$JAVA_HOME" ]; then
      export JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')
    fi
    ```
    
    Or, keeping it for RHEL in the default file but using in ExecStart:
    
    ```
    [ -d "$JAVA_HOME" ] || export JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')
    ```
    

> Systemd packaging for Ubuntu 16.04
> ----------------------------------
>
>                 Key: CLOUDSTACK-9462
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9462
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>             Fix For: 4.10.0, 4.9.1
>
>
> Support for building deb packages that will work on Ubuntu 16.04


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)