cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9480) Egress Firewall: Incorrect use of Allow/Deny for ICMP
Date Tue, 30 Aug 2016 08:17:21 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448414#comment-15448414
] 

ASF GitHub Bot commented on CLOUDSTACK-9480:
--------------------------------------------

GitHub user murali-reddy opened a pull request:

    https://github.com/apache/cloudstack/pull/1666

    CLOUDSTACK-9480: Egress Firewall: Incorrect use of Allow/Deny for ICMP

    When 'default egress policy' is set to 'allow' in the network offering, any egress rule
that is added will 'deny' the traffic overriding the default behaviour.
    
    Conversely, when 'default egress policy' is set to 'deny' in the network offering, any
egress rule that is added will 'allow' the traffic overriding the default behaviour.
    
    While this works for 'tcp', 'udp' as expected, for 'icmp' protocol its always set to ALLOW.
This patch keeps all protocols behaviour consistent.
    
    Results of running test/integration/component/test_egress_fw_rules.py.  With out the patch
test_02_egress_fr2 test was failing. This patch fixes the test_02_egress_fr2  scenario. 
    -----------------------------------------------------------------------------------------------------
    Test By-default the communication from guest n/w to public n/w is NOT allowed. ... ===
TestName: test_01_1_egress_fr1 | Status : SUCCESS ===
    ok
    Test By-default the communication from guest n/w to public n/w is allowed. ... === TestName:
test_01_egress_fr1 | Status : SUCCESS ===
    ok
    Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. ... ===
TestName: test_02_1_egress_fr2 | Status : SUCCESS ===
    ok
    Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. ... ===
TestName: test_02_egress_fr2 | Status : SUCCESS ===
    ok
    Test Communication blocked with network that is other than specified ... === TestName:
test_03_1_egress_fr3 | Status : SUCCESS ===
    ok
    Test Communication blocked with network that is other than specified ... === TestName:
test_03_egress_fr3 | Status : SUCCESS ===
    ok
    Test Create Egress rule and check the Firewall_Rules DB table ... === TestName: test_04_1_egress_fr4
| Status : SUCCESS ===
    ok
    Test Create Egress rule and check the Firewall_Rules DB table ... === TestName: test_04_egress_fr4
| Status : SUCCESS ===
    ok
    Test Create Egress rule and check the IP tables ... SKIP: Skip
    Test Create Egress rule and check the IP tables ... SKIP: Skip
    Test Create Egress rule without CIDR ... === TestName: test_06_1_egress_fr6 | Status :
SUCCESS ===
    ok
    Test Create Egress rule without CIDR ... === TestName: test_06_egress_fr6 | Status : SUCCESS
===
    ok
    Test Create Egress rule without End Port ... === TestName: test_07_1_egress_fr7 | Status
: EXCEPTION ===
    ERROR
    Test Create Egress rule without End Port ... === TestName: test_07_egress_fr7 | Status
: SUCCESS ===
    ok
    Test Port Forwarding and Egress Conflict ... SKIP: Skip
    Test Port Forwarding and Egress Conflict ... SKIP: Skip
    Test Delete Egress rule ... === TestName: test_09_1_egress_fr9 | Status : SUCCESS ===
    ok
    Test Delete Egress rule ... === TestName: test_09_egress_fr9 | Status : SUCCESS ===
    ok
    Test Invalid CIDR and Invalid Port ranges ... === TestName: test_10_1_egress_fr10 | Status
: SUCCESS ===
    ok
    Test Invalid CIDR and Invalid Port ranges ... === TestName: test_10_egress_fr10 | Status
: SUCCESS ===
    ok
    Test Regression on Firewall + PF + LB + SNAT ... === TestName: test_11_1_egress_fr11 |
Status : SUCCESS ===
    ok
    Test Regression on Firewall + PF + LB + SNAT ... === TestName: test_11_egress_fr11 | Status
: SUCCESS ===
    ok
    Test Reboot Router ... === TestName: test_12_1_egress_fr12 | Status : SUCCESS ===
    ok
    Test Reboot Router ... === TestName: test_12_egress_fr12 | Status : EXCEPTION ===
    ERROR
    Test Redundant Router : Master failover ... === TestName: test_13_1_egress_fr13 | Status
: SUCCESS ===
    ok
    Test Redundant Router : Master failover ... === TestName: test_13_egress_fr13 | Status
: SUCCESS ===
    ok
    -----------------------------------------------------------------------------------------------------

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/murali-reddy/cloudstack egress_rules

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1666.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1666
    
----
commit 3eec421646289549e939c43ed9cbb1fd657a72a4
Author: Murali Reddy <muralimmreddy@gmail.com>
Date:   2016-08-30T08:09:26Z

    CLOUDSTACK-9480: Egress Firewall: Incorrect use of Allow/Deny for ICMP
    
    When 'default egress policy' is set to 'allow' in the network offering, any egress rule
that is added will 'deny' the traffic overriding the default behaviour.
    
    Conversely, when 'default egress policy' is set to 'deny' in the network offering, any
egress rule that is added will 'allow' the traffic overriding the default behaviour.
    
    While this works for 'tcp', 'udp' as expected, for 'icmp' protocol its always set to ALLOW.
This patch keeps all protocols behaviour consistent.

----


> Egress Firewall: Incorrect use of Allow/Deny for ICMP
> -----------------------------------------------------
>
>                 Key: CLOUDSTACK-9480
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9480
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Network Controller
>    Affects Versions: 4.6.2, 4.7.1, 4.8.0, 4.9.0
>            Reporter: Murali Reddy
>            Assignee: Murali Reddy
>             Fix For: 4.9.1
>
>
> When 'default egress policy' is set to 'allow' in the network offering, any egress rule
that is added will 'deny' the traffic overriding the default behaviour. 
> Conversely, when 'default egress policy' is set to 'deny' in the network offering, any
egress rule that is added will 'allow' the traffic overriding the default behaviour. 
> While this works for 'tcp', 'udp' as expected, for 'icmp' protocol its always set to
ALLOW.
> Egress firewall rule behaviour should be consistent for all the protocols.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message