cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9462) Systemd packaging for Ubuntu 16.04
Date Fri, 26 Aug 2016 09:40:20 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438719#comment-15438719
] 

ASF GitHub Bot commented on CLOUDSTACK-9462:
--------------------------------------------

Github user vincentbernat commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1647#discussion_r76392345
  
    --- Diff: packaging/systemd/cloudstack-agent.default ---
    @@ -0,0 +1,24 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +
    +JAVA_HOME=/usr/lib/jvm/jre
    +if [ ! -f "$JAVA_HOME"/bin/java ] ; then
    +    JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')
    +fi
    --- End diff --
    
    I think the result is quite fragile. systemd just reads the first JAVA_HOME, then the
second one, ignoring the condition. You could just have (without the condition):
    
    ```
    JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')
    ```
    
    The only use of JAVA_HOME seems to be to choose a Java vesion. Why not just, in `/etc/default/...`:
    
    ```
    JAVA=/usr/bin/java
    ```
    
    And in the service file:
    
    ```
    ExecStart=/bin/sh -ec '\
         export ACP=`ls /usr/share/cloudstack-agent/lib/*.jar /usr/share/cloudstack-agent/plugins/*.jar
2>/dev/null|tr "\\n" ":"`; \
         export CLASSPATH="$ACP:/etc/cloudstack/agent:/usr/share/cloudstack-common/scripts";
\
    ${JAVA} -Xms${JAVA_HEAP_INITIAL} -Xmx${JAVA_HEAP_MAX} -cp "$CLASSPATH" $JAVA_CLASS'
    ```
    
    People could still overload the version of Java used by changing the JAVA variable.
    
    If you are uncomfortable with this, at least, just remove the condition and simplify the
default file to be:
    
    ```
    JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')
    JAVA_HEAP_INITIAL=256m
    JAVA_HEAP_MAX=2048m
    JAVA_CLASS=com.cloud.agent.AgentShell
    ```
    
    From your tests, it works both on Ubuntu and CentOS.


> Systemd packaging for Ubuntu 16.04
> ----------------------------------
>
>                 Key: CLOUDSTACK-9462
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9462
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>             Fix For: 4.10.0, 4.9.1
>
>
> Support for building deb packages that will work on Ubuntu 16.04



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message