cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9458) Some VMs are being stopped when agent is reconnecting
Date Mon, 22 Aug 2016 21:07:21 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431630#comment-15431630
] 

ASF GitHub Bot commented on CLOUDSTACK-9458:
--------------------------------------------

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1640#discussion_r75758946
  
    --- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
    @@ -497,7 +498,7 @@ protected Long restart(final HaWorkVO work) {
     
                     boolean fenced = false;
                     if (alive == null) {
    -                    s_logger.debug("Fencing off VM that we don't know the state of");
    +                    s_logger.debug("Fencing off VM " + vm + " that we don't know the
state of");
    --- End diff --
    
    In my view, the ``Supplier`` approach is just as complex, but in another way.  In the
long term, we will be adopting SLF4J which supports string templates -- allowing constructs
as such as:
    
    ```
    LOG.debug("I am having a problem VM %s", vm.getId());
    ```
    
    This approach defers string concatenation in a more straight forward manner.


> Some VMs are being stopped when agent is reconnecting
> -----------------------------------------------------
>
>                 Key: CLOUDSTACK-9458
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9458
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Marc-Aurèle Brothier
>            Assignee: Marc-Aurèle Brothier
>
> If you loose the communication between the management server and one of the agent for
a few minutes, even though HA mode is not active the HighAvailibilityManager kicks in and
start to schedule vm restart. Those tasks are being inserted as async job in the DB and if
the agent comes back online during the time the jobs are still in the async table, they are
pushed to the agent and shuts down the VMs. Then since HA is not active, the VM are not restarted.
> The expected behavior in my opinion is that the VM should not be restarted at all if
HA mode is not active on them, and let the agent update the VM state with the power report.
> The bug lies in {{HighAvailibilityManagerImpl.scheduleRestartForVmsOnHost(final HostVO
host, boolean investigate)}}, PR will follow.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message