Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Mon, 11 Jul 2016 19:33:11 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12988398.1468264870000.82942.1468265591026@Atlassian.JIRA>
In-Reply-To: <JIRA.12988398.1468264870000@Atlassian.JIRA>
References: <JIRA.12988398.1468264870000@Atlassian.JIRA> <JIRA.12988398.1468264870066@arcas>
Subject: [jira] [Commented] (CLOUDSTACK-9430) Adding a network ACL rule adds
 it in the wrong order for VPCs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 11 Jul 2016 19:33:12 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371470#comment-15371470 ] 

ASF GitHub Bot commented on CLOUDSTACK-9430:
--------------------------------------------

GitHub user pdube opened a pull request:

    https://github.com/apache/cloudstack/pull/1609

    [CLOUDSTACK-9430] Added fix for adding/editing Network ACL rule ordering

    BUG: https://issues.apache.org/jira/browse/CLOUDSTACK-9430
    
    The issue occurred because all of the ACL rules get inserted before the old ones. Then, the cleanup deletes the duplicate rows, and leaves any new rule in front of the old ones.
    
    Here is an example with a simplified iptables view for ACL
    Ex: adding a rule 4
    before add:
    1,2,3
    
    during add:
    1',2',3',4',1,2,3
    
    after add:
    4',1,2,3
    
    After fix:
    before add:
    1,2,3
    
    during add:
    1,2,3,1',2',3',4'
    
    after add:
    1',2',3',4'


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pdube/cloudstack network-acl-add-order

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1609.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1609
    
----
commit 6dd6ef0c9a30f128657de22fa8b6ea8ab5daa133
Author: Patrick Dube <pdube@cloudops.com>
Date:   2016-07-11T19:12:41Z

    Added fix for adding/editing Network ACL rule ordering

----


> Adding a network ACL rule adds it in the wrong order for VPCs
> -------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9430
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9430
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.7.1, 4.8.0, 4.9.0
>            Reporter: Patrick D.
>
> Editing a rule number as well.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)